Skip to content

Move from alpharaw#275

Merged
mschwoer merged 17 commits into
mainfrom
move_from_alpharaw
Jun 2, 2026
Merged

Move from alpharaw#275
mschwoer merged 17 commits into
mainfrom
move_from_alpharaw

Conversation

@mschwoer

@mschwoer mschwoer commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Move code over from alpharaw (cf. MannLabs/alpharaw#116)

@GeorgWa GeorgWa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we get rid of the NormalDIAGrouper?
It's not used anywhere to my knowledge.

@jalew188

jalew188 commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Looks good! Could we get rid of the NormalDIAGrouper? It's not used anywhere to my knowledge.

Greet, now we have alphadia to do this

@mschwoer

Copy link
Copy Markdown
Contributor Author

@GeorgWa @jalew188 unfortunately, not:

Yes, NormalDIAGrouper is actively used. Here's the full call chain:

  1. NormalDIAGrouper — defined in match/normal_dia.py:11, instantiated in match/psm_match.py:529
  2. PepSpecMatch_DIA._match_ms2_one_raw_numba (match/psm_match.py:497) — the method that creates the NormalDIAGrouper
  3. PepSpecMatch._match_ms2_one_raw_numba is called at match/psm_match.py:429 (polymorphic call via self, dispatches to the DIA override)
  4. This is called from match_psms() (pipeline_api.py:152), which creates PepSpecMatch_DIA at line 212 when the PSM type is not DDA
  5. match_psms() is called from transfer_learn() (pipeline_api.py:360)
  6. transfer_learn() is called from:
    - cli.py:133 and cli.py:170 (CLI entry points)
    - webui/server.py:57 (web UI)

  So NormalDIAGrouper is actively in use — it's part of the DIA PSM matching pipeline, reachable from both the CLI and the web UI via transfer_learn -> match_psms -> PepSpecMatch_DIA._match_ms2_one_raw_numba.

@mschwoer mschwoer merged commit e61c932 into main Jun 2, 2026
2 checks passed
@mschwoer mschwoer deleted the move_from_alpharaw branch June 2, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants