Skip to content

remove unused fragments from input during multiplexing #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mschwoer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove unused fragments from input during multiplexing #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions alphadia/libtransform/multiplex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def forward(self, input: SpecLibBase) -> SpecLibBase:
input.precursor_df = input.precursor_df[
input.precursor_df["channel"] == self._input_channel
]
input.remove_unused_fragments()

@GeorgWa GeorgWa Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should always be safe to call. I'm still a bit surprised it's needed.

@mschwoer mschwoer Mar 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do you think it's worth digging a bit deeper? maybe this is just the symptomatic cure for a more severe bug?


channel_lib_list = []
for channel, channel_mod_translations in self._multiplex_mapping.items():
Expand Down
Loading