Skip to content

Update dependencies#16

Merged
O-Hannonen merged 16 commits intoMankeli-Software:mainfrom
vanyasem:main-sem
May 24, 2025
Merged

Update dependencies#16
O-Hannonen merged 16 commits intoMankeli-Software:mainfrom
vanyasem:main-sem

Conversation

@vanyasem
Copy link
Contributor

@vanyasem vanyasem commented Oct 23, 2024

Description

Fixes #14

Blocked by Mankeli-Software/mankeli_core#2. UPD: The PR has been merged
Blocked by Mankeli-Software/cmd_plus#10. UPD: The PR has been merged

Conventional Type

  • ✨ feat
  • 🛠️ fix
  • ✅ chore
  • 📝 doc
  • 🧪 test
  • ❌ BREAKING CHANGE

@vanyasem
Copy link
Contributor Author

vanyasem commented Oct 23, 2024

I can see that Flutter version is set to 3.10.5:

flutter-version: 3.10.5

Is there a reason to keep it at 3.10.5, or can it be updated to the latest version?

The CI has failed because pub_updater 0.5.0 requires Dart SDK 3.5.0+ (Flutter 3.24.0), while GitHub Actions has Dart 3.0.0 (Flutter 3.10.5). See VeryGoodOpenSource/pub_updater#62

However, pub_updater 0.4.0 has no such requirement - if preserving compatibility with 3.10.5 is a priority, I can roll back pub_updater to 0.4.0, which would still solve the issue #14

freezed ^3.0.0 requires Dart SDK 3.6.0+ (Flutter 3.27.0)

Copy link

@dacianf dacianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I would upgrade all libs to latest compatible

@vanyasem
Copy link
Contributor Author

vanyasem commented May 24, 2025

I've created a new PR in cmd_plus: Mankeli-Software/cmd_plus#10. It updates some dependencies that prevent my this PR from being updated further.
UPD: The PR has been merged

@vanyasem
Copy link
Contributor Author

vanyasem commented May 24, 2025

Updated the PR:

  • bumps the minimum required Dart SDK version up to ^3.6.0
  • removes DCM dependencies
  • updates cli_completion to ^0.5.0
  • updates pub_updater to ^0.5.0
  • updates cmd_plus to ^1.3.4
  • migrates freezed & freezed_annotation to ^3.0.0 (https://github.com/rrousselGit/freezed/blob/master/packages/freezed/migration_guide.md)
  • migrates json_annotation to ^4.9.0: The version constraint "^4.8.9" on json_annotation allows versions before 4.9.0 which is not allowed.

I've regenerated freezed & json_annotation code

I'd consider this PR ready to merge

I've updated the CI workflow to use Flutter 3.27.0 (which is the new earliest supported Flutter version)

@vanyasem
Copy link
Contributor Author

The CI check passed 🎉

@O-Hannonen
Copy link
Contributor

Thank you for your contribution! 💯

@O-Hannonen O-Hannonen merged commit d2a72d9 into Mankeli-Software:main May 24, 2025
1 check passed
@vanyasem
Copy link
Contributor Author

Oops, sorry for the publish_to: none
I've been using this package in most of my projects, got used to the fact it's an unofficial fork!

@vanyasem
Copy link
Contributor Author

Thank you for taking your time to review & merge the PRs. I really appreciate it
I really enjoy using dart_define - it's amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Dependency on pub_updater is outdated and needs to be updated to pub_updater: ^0.4.0

3 participants