Do not download unused submodules for CPM package #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake let's you define a list of submodules that should be downloaded when fetching remote repos, see ExternalProject docs (same mechanism is used for the FetchContent commands, see here.
For valijson we do not want any submodules to be downloaded, but CPM does not currently parse the option
GIT_SUBMODULES ""correctly. There seems to be issues with handling empty strings.However, there is a workaround: specify an existing subdir from the repo to not download any submodules.
This small change will speed up the CMake config a bit and reduce the size of the build folder, as we skip downloading seven remote projects.