v2 beta: upgrade to dual ESM + CJS output, use confidential client as the client type#13
Merged
v2 beta: upgrade to dual ESM + CJS output, use confidential client as the client type#13
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares @makerx/express-msal v2 beta for a modern Node 20+ toolchain by adding dual ESM+CJS build output, updating lint/test tooling, and aligning the MSAL client typing to IConfidentialClientApplication.
Changes:
- Switch TypeScript config to Node 20 + no-emit typechecking, and introduce a dedicated build tsconfig for dist output.
- Replace
tscbuild with Rollup to emit both CJS and ESM artifacts, and migrate tests from Jest to Vitest. - Update public API typing to accept an
IConfidentialClientApplicationand refresh docs/configuration files.
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Move to Node 20 baseline and typecheck-only configuration. |
tsconfig.build.json |
Build-specific emit settings for declarations and dist output. |
src/index.ts |
Update MSAL client type to IConfidentialClientApplication and tighten response typing. |
rollup.config.ts |
New Rollup build for dual ESM + CJS outputs. |
package.json |
v2 beta versioning, Node engine bump, new build/lint/test scripts, peer/dev dependency updates. |
jest.config.ts |
Remove Jest configuration as part of Vitest migration. |
eslint.config.mjs |
New ESLint flat-config setup using @makerx/eslint-config. |
README.md |
Update package name, examples, and Express 5 note; fix minor wording. |
.vscode/tasks.json |
Add VS Code tasks for lint and typecheck. |
.tstoolkitrc.ts |
Add ts-toolkit config for copy-package-json step. |
.prettierrc.cjs / .prettierrc |
Switch to shared Prettier config package. |
.nsprc |
Document advisory suppression rationale. |
.gitignore |
Expand ignored files (pnpm logs, IDE files, build output, env files, test results). |
.github/workflows/publish.yml |
Switch to trusted publishing workflow. |
.eslintrc.js / .eslintignore |
Remove legacy ESLint config files. |
.editorconfig |
Update max line length to 100. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.