-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add CSS to clock module to prevent line breaking of sunrise/sunset information #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, but as there is not an open issue: Could you please provide a screenshot from before and one from after your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup. some paddings can be done more elegantly though.
I've simplified it, but I think the |
@rejas can you please re-review? |
sorry for not doing it before the release. i took the liberty of adding my line of thought and code to your PR. what do you think about it @dathbe ? |
I haven't tested it yet, but assuming someone has I don't have any problem with your implementation of the 3px gap. |
Done |
sorry for being not clear enough, I wanted @rejas to fix this because he asked for review and he missed the release ;) But anyway, thanks! |
develop
branch.Done
No
Fixes #<issue_number>
?N/A
With some combinations of sunrise and sunset times (usually when the time till rise/set is >9:59), the information will break across multiple lines. This prevents that by adding CSS.
I don't consider it major.
npm run lint:prettier
before submitting so that style issues are fixed.Done
Done