Skip to content

Add CSS to clock module to prevent line breaking of sunrise/sunset information #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 2, 2025

Conversation

dathbe
Copy link

@dathbe dathbe commented Jun 23, 2025

  1. Base your pull requests against the develop branch.
    Done
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
    No
  • If so, can you reference the issue like this Fixes #<issue_number>?
    N/A
  • What does the pull request accomplish? Use a list if needed.
    With some combinations of sunrise and sunset times (usually when the time till rise/set is >9:59), the information will break across multiple lines. This prevents that by adding CSS.
  • If it includes major visual changes please add screenshots.
    I don't consider it major.
  1. Please run npm run lint:prettier before submitting so that style issues are fixed.
    Done
  2. Don't forget to add an entry about your changes to the CHANGELOG.md file.
    Done

@dathbe dathbe changed the title Patch 2 Add CSS to clock module to prevent line breaking of sunrise/sunset information Jun 23, 2025
@KristjanESPERANTO
Copy link
Collaborator

Looks good, but as there is not an open issue: Could you please provide a screenshot from before and one from after your changes?

@dathbe
Copy link
Author

dathbe commented Jun 23, 2025

Before:
before

After:
after

@dathbe
Copy link
Author

dathbe commented Jun 23, 2025

After spacing cleaned up:

after2

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup. some paddings can be done more elegantly though.

@dathbe
Copy link
Author

dathbe commented Jun 24, 2025

I've simplified it, but I think the padding-top for .sun and .moon is still needed because adding flex to the digital class completely rearranges the elements of the module.

@khassel
Copy link
Collaborator

khassel commented Jun 29, 2025

@rejas can you please re-review?

@rejas
Copy link
Collaborator

rejas commented Jul 1, 2025

sorry for not doing it before the release. i took the liberty of adding my line of thought and code to your PR. what do you think about it @dathbe ?

@dathbe
Copy link
Author

dathbe commented Jul 1, 2025

I haven't tested it yet, but assuming someone has I don't have any problem with your implementation of the 3px gap.

@rejas rejas requested a review from khassel July 1, 2025 20:40
@dathbe
Copy link
Author

dathbe commented Jul 2, 2025

Done

@khassel
Copy link
Collaborator

khassel commented Jul 2, 2025

Done

sorry for being not clear enough, I wanted @rejas to fix this because he asked for review and he missed the release ;)

But anyway, thanks!

@khassel khassel merged commit 3a2a52c into MagicMirrorOrg:develop Jul 2, 2025
9 checks passed
@dathbe dathbe deleted the patch-2 branch July 2, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants