Fix chosen tags #258
Fix chosen tags #258
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Hey, left you some comments.
| for (const exisitingTag of existingTags) { | ||
| // we set tags chosen to active and all the others to not | ||
| if (existingTags.every(value => value.isActive)) { | ||
| existingTags.forEach(existingTag => { |
There was a problem hiding this comment.
Instead of putting comment explaining your code you could extract this part into a function and call it
| }); | ||
|
|
||
| if (existingTags.every(value => !value.isActive)) { | ||
| existingTags.forEach(existingTag => { |
There was a problem hiding this comment.
You can save the existingTags.every(value => !value.isActive from before into a boolean and check it in here (you would probably need to check for !yourBooleanValue)
And you will save one array function
| // const handleBtnFilterClick = (filter: ProjectFilter) => { | ||
| // handleFilterOptionChange(filter); | ||
| // }; | ||
|
|
There was a problem hiding this comment.
Remove the comments please
| filters: ProjectFilter[]; | ||
| handleFilterOptionChange: any; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please change the name to FiltersWindowProps like we do in the project for components props.
Also don't use any , change your interface to have defined values.
| {t('projectsFilters')}{' '} | ||
| </h3> | ||
| {/* sort by ProjectPaginationFilter (sortoptions,sortoptionsmapper) */} | ||
| <div className="flex gap-4 md:gap-[26px] justify-center md:justify-normal md:items-center"> |
| <div | ||
| ref={filterRef} | ||
| className="z-[101] absolute -bottom-[23.5rem] md:-bottom-[16.75rem] right-2 px-[34px] py-[27px] rounded-md border border-blue-600 min-w-[300px] md:min-w-0 md:w-[863px] min-h-[260px] md:h-[209px] p-5 bg-gray-50 dark:bg-gray-600" | ||
| > |
There was a problem hiding this comment.
Do you need the z-[101]? will it work with smaller z index ?
| onChange={handleCategoryOptionSelection} | ||
| /> | ||
| ))} | ||
| </div> |
There was a problem hiding this comment.
Optional - This could be extracted into a separate component, let's say RadioboxList
|
@DeanYona Can you address the changes anytime soon? |
|
@Tamir198 can you take over and apply the changes you recommended? |
|
@Darkmift Maybe later on this week |
|
I was not avle not find time for this sorry |
3 participants
i solved it and now the programming languages you pressed are the ones active unless none chosen and then all are active.
Fixes #257