fix(KWin): correct MaaKWinControllerCreate signature#1369
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我已经审查了你的更改,看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaaKWinControllerCreate的头文件声明和实际定义参数对不上头文件 include/MaaFramework/Instance/MaaController.h(3个参数):
MAA_FRAMEWORK_API MaaController* MaaKWinControllerCreate(const char* device_node, int screen_width, int screen_height);定义 source/MaaFramework/API/MaaFramework.cpp(4个参数):
MaaController* MaaKWinControllerCreate(const char* device_node, int screen_width, int screen_height, MaaBool use_win32_vk_code)两处定义(
MaaFramework.cpp和MaaAgentServerNotImpl.cpp)都是4个参数 只有头文件是3个 下游按头文件链接会炸Summary by Sourcery
通过在头文件中添加缺失的参数并记录其行为,使
MaaKWinControllerCreate公共 API 声明与其实现保持一致。New Features:
use_win32_vk_code参数的用途,该参数用于控制 KWin 控制器中从 Win32 Virtual-Key 到 Linux evdev 键码的转换。Bug Fixes:
MaaKWinControllerCreate函数在公共头文件与源文件实现之间的函数签名不匹配问题,以防止下游用户在链接阶段出现问题。Original summary in English
Summary by Sourcery
Align the MaaKWinControllerCreate public API declaration with its implementation by adding the missing parameter to the header and documenting its behavior.
New Features:
Bug Fixes: