Merged
Conversation
6788d67 to
6430038
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 60 +15
Lines 2242 4016 +1774
===========================================
+ Hits 2242 4016 +1774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feldlime
reviewed
Jan 16, 2025
Collaborator
feldlime
left a comment
There was a problem hiding this comment.
Thanks for the PR, it looks super cool!
Contributor
Author
|
Python 3.9 CI fails because of codecov issue. Test is passed.
|
Contributor
Author
|
@feldlime I addressed all the comments you made. PTAL |
Contributor
Author
|
@feldlime Updated the changelog, as well as the order of assignment. |
feldlime
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce
use_gpufor PureSVD.My microbenchmark code shows 8 times faster than CPU with Movielens 1M dataset on GeForce 3060Ti compared with Ryzen 5 5600X.
Environment information:
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.