Draft
Conversation
This means that 2 descriptors related to chords need to dissapear as these are not supported in new analyzer. These were not very relevant to Freesound anyway, and probably very faulty.
We'll no longer use it as with the new essentia extractor we don't compute "frames" files. This commit also removes the "analysis" entry in sound locations as this has been managed by SoundAnalysis objects since these were introduced and we don't need it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove usage of legacy Essentia extractor. We've been running "legacy" and "v1" extractors for a while. They are mostly compatible although there are some small differences. We need to switch to "v1" for maintainability, etc.
Main differences:
Deployment steps:
After this is merged, we need to update local settings of deployment configuration so that we no longer use legacy analyzer for any similarity space and we remove it from analyzer's configuration dict. Then we can get rid of all SoundAnalysis objects that belong to the legacy analyzer, and also all files on disk (including frames analysis). We should re-run "consolidate analysis" for all files so descriptor values are now loaded from the new extractor (this is is actually not mandatory, but nice to do in case there were some differences between legacy and v1).