Signalement adresse transmise à l'IGN #1555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
============================================
+ Coverage 97.27% 97.29% +0.02%
- Complexity 2579 2606 +27
============================================
Files 508 509 +1
Lines 10933 11032 +99
============================================
+ Hits 10635 10734 +99
Misses 298 298 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Est-ce que tu peux rajouter les tests manquants dans ton handler et ton IGNClient pour remonter le coverage ? 🙏 |
Lealefoulon
force-pushed
the
feat/report-address-api-ign
branch
2 times, most recently
from
494925e to
65c8f80
Compare
mmarchois
reviewed
Dec 16, 2025
Lealefoulon
force-pushed
the
feat/report-address-api-ign
branch
from
65c8f80 to
5a240e7
Compare
mmarchois
reviewed
Dec 17, 2025
tests/Unit/Application/User/Command/SaveReportAddressCommandHandlerTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Application/User/Command/SaveReportAddressCommandHandlerTest.php
Outdated
Show resolved
Hide resolved
Lealefoulon
force-pushed
the
feat/report-address-api-ign
branch
2 times, most recently
from
3b2ea2b to
d6fc6db
Compare
Lealefoulon
force-pushed
the
feat/report-address-api-ign
branch
from
d6fc6db to
9513219
Compare
mmarchois
reviewed
Dec 23, 2025
Collaborator
mmarchois
left a comment
mmarchois
left a comment
There was a problem hiding this comment.
Super taf, j'ai juste quelques petites suggestions
src/Application/User/Command/SaveReportAddressCommandHandler.php
Outdated
Show resolved
Hide resolved
Lealefoulon
force-pushed
the
feat/report-address-api-ign
branch
from
c303169 to
52c455c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://espacecollaboratif.ign.fr/gcms/api/doc/#generalites
https://espacecollaboratif.ign.fr/profile/