Skip to content

Tweaked user counts section formatting #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Tweaked user counts section formatting #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37e1f36
Bring user counts markup in line with current site. Likes span is now…
smallsaucepan Sep 5, 2025
d3584d7
Made likes link text same colour as rest of panel. Removed extra widt…
smallsaucepan Sep 5, 2025
c648339
Reordered the sub and sup element text examples to better demonstrate…
smallsaucepan Sep 5, 2025
dddeb5f
Forgot to lint :\
smallsaucepan Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base/examples/text-semantics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
The <small>small element</small> example <br />
The <span>span element</span> example <br />
The <strong>strong element</strong> example <br />
The <sub>sub element</sub> example <br />
The <sup>sup element</sup> example <br />
The <sub>sub element</sub> example <br />
The <var>var element</var> example <br />
The <u>u element</u> example
</p>
6 changes: 2 additions & 4 deletions src/components/user-counts/_user-counts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@
width: 70px; // magic number that works in the sidebar

.num {
color: inherit;
display: block;
font-size: 1.125rem;
font-weight: var(--number-font-weight-bold);
text-decoration-color: inherit;
}

.label {
Expand All @@ -35,10 +37,6 @@
}
}

.views {
width: 95px; // magic number to give views more space than other cells
}

.saves {
color: var(--color-status-warning);
}
Expand Down
6 changes: 3 additions & 3 deletions src/components/user-counts/examples/user-counts-narrow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
<div name="username" class="user-counts">
<ul>
<li class="views">
<span class="num">7,438,959</span>
<span class="num">7.4M</span>
<span class="label-text">Views</span>
</li>
<li class="saves">
<span class="num">22,511</span>
<span class="num">22.5K</span>
<span class="label-text">Saves</span>
</li>
<li class="likes">
<span class="num">140,205</span>
<a class="num" href="#">140.2K</a>
<span class="label-text">Likes</span>
</li>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions src/components/user-counts/examples/user-counts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<div name="username" class="user-counts">
<ul>
<li class="views">
<span class="num">24,853</span>
<span class="num">24.8K</span>
<span class="label-text">Views</span>
</li>
<li class="saves">
<span class="num">38</span>
<span class="label-text">Saves</span>
</li>
<li class="likes">
<span class="num">374</span>
<a class="num" href="#">374</a>
<span class="label-text">Likes</span>
</li>
</ul>
Expand Down