Remove space from php-timezone sed pattern#399
Merged
ostefano merged 19 commits intoMISP:masterfrom Mar 20, 2026
Merged
Conversation
Add timezone setting option to template.env
- Add timezone environment variable to all services - Setting Default to "UTC"
- Add timezone configuration for PHP in docker-compose file. - Replace PHP timezone in misp-core with the new config-file tzone.ini Perhaps there are better solutions for changing the time zone from PHP during runtime.
Updated PHP timezone configuration and added symlink for timezone for supervisord.
sed dosen´t use "?" so PHP_TIMEZONE was setting in php.ini
PHP_TIMEZONE wasn`t in template.env and so most not in use. TZ Variable the global Timezone variable in this Project
Removed timezone configuration from docker-compose. With the "sed fix" in the entrypoint_fpm.sh, No need to mount a separate file now
Updated timezone setting method for supervisord compatibility with debian standard methode
add `-` so default (UTC) is in use, if TZ is not in use
PHP_timezone isn`t in use TZ exist
CET or CEST not useable timezone in /usr/share/zoneinfo/
Remove default value for TZ when setting timezone.
switch delimitter `/` to `|`
Remove the space from the pattern (`= .*` → `=.*`) to make it more flexible.
ostefano
reviewed
Mar 20, 2026
| sed -i "s/session.sid_length = .*/session.sid_length = 64/" "$FILE" | ||
| sed -i "s/session.use_strict_mode = .*/session.use_strict_mode = 1/" "$FILE" | ||
| echo "Configure PHP | Setting 'date.timezone = ${TZ}'" | ||
| sed -i "s|^;date.timezone = .*|date.timezone = ${TZ}|" "$FILE" |
Collaborator
There was a problem hiding this comment.
Why do we need to fix it?
My understanding is that, if this is never modified manually, it should work consistently?
Contributor
Author
There was a problem hiding this comment.
The problem is that, by default, the php.ini file does not appear to have a space after ;date.timezone =. As a result, the pattern does not recognize this line and does not set the value.
Without the space in the pattern, it is therefore more robust.
Collaborator
There was a problem hiding this comment.
Oh, that is indeed annoying...
ostefano
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the space from the pattern (
= .*→=.*) to make it more flexible.Solution for #398
sorry for my mistake :/