Merged
Conversation
Game Test Results✅ Success
Workflow run: #419 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Jade (WTHIT) compatibility to display Abyss Spawner cooldown information in the tooltip UI, plus supporting localization/utility updates.
Changes:
- Introduce a Jade plugin + component provider that sends spawner cooldown from server to client tooltip.
- Track and expose remaining cooldown ticks in
AbyssTrialSpawner. - Add tooltip localization key(s) and minor lang/tag ordering fixes.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/assets/mia/lang/default/tooltip.json |
Adds default tooltip translation for abyss spawner cooldown. |
src/main/java/com/altnoir/mia/util/MiaUtil.java |
Adds tick-to-mm:ss formatting helper. |
src/main/java/com/altnoir/mia/core/spawner/AbyssTrialSpawner.java |
Tracks/exposes remaining cooldown for external UI. |
src/main/java/com/altnoir/mia/compat/jade/MiaJadePlugin.java |
Registers Jade providers for Abyss Spawner tooltip/data. |
src/main/java/com/altnoir/mia/compat/jade/AbyssSpawnerComponentProvider.java |
Sends cooldown via serverData + renders tooltip line. |
src/generated/resources/data/mia/tags/item/artifact_modifiers_material.json |
Reorders tag values (no functional change). |
src/generated/resources/assets/mia/lang/en_us.json |
Fixes spacing typo and adds abyss spawner cooldown translation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/altnoir/mia/compat/jade/AbyssSpawnerComponentProvider.java
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.