Skip to content

Binary L2 mass-loss fraction for thin accretion disk #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

pmocz
Copy link
Member

@pmocz pmocz commented May 29, 2025

This PR begins to implement some useful features for modeling thin accretion disks and mass transfer/loss in binary systems.

Here, we implement an internal function (made callable in run_stars_extras as binary_L2_mass_loss_fraction()) to

  • calculate the (outer) L2 mass-loss fraction according to Lu et al. (2023) "On rapid binary mass transfer -I. Physical model"

and adds unit tests

@pmocz pmocz requested review from matthiasfabry and mathren May 29, 2025 11:49
@pmocz pmocz self-assigned this May 29, 2025
@pmocz pmocz requested a review from orlox as a code owner May 29, 2025 11:49
@pmocz
Copy link
Member Author

pmocz commented Jun 5, 2025

Currently, this function calculates the fL2_{outer} mass loss using Kramers opacity law. It looks like this (e.g., for q=0.5, M_2=10 Msun, X=0.7, Z=0.02)

image

@pmocz
Copy link
Member Author

pmocz commented Jun 5, 2025

verified against: https://github.com/wenbinlu/L2massloss

@warrickball
Copy link
Contributor

warrickball commented Jun 7, 2025

I've suggested powN(x) instead of x**N for N > 2, following our code style for exponents, and a bit more constant re-use (even for such details as ⅔).

Also note that the published version of the reference is Lu et al. (2023), not (2022).

Co-authored-by: Warrick Ball <[email protected]>
@pmocz
Copy link
Member Author

pmocz commented Jun 8, 2025

Thanks for all the fixes to help with bit-for-bit reproduction across compilers, @warrickball !

Co-authored-by: Warrick Ball <[email protected]>
pmocz and others added 18 commits June 8, 2025 13:05
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
@pmocz pmocz requested a review from rhdtownsend as a code owner June 8, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants