-
Notifications
You must be signed in to change notification settings - Fork 48
Binary L2 mass-loss fraction for thin accretion disk #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmocz
wants to merge
23
commits into
main
Choose a base branch
from
pmocz/feature/fL2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verified against: https://github.com/wenbinlu/L2massloss |
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
I've suggested Also note that the published version of the reference is Lu et al. (2023), not (2022). |
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
warrickball
reviewed
Jun 7, 2025
Co-authored-by: Warrick Ball <[email protected]>
Thanks for all the fixes to help with bit-for-bit reproduction across compilers, @warrickball ! |
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Co-authored-by: Warrick Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to implement some useful features for modeling thin accretion disks and mass transfer/loss in binary systems.
Here, we implement an internal function (made callable in run_stars_extras as
binary_L2_mass_loss_fraction()
) toand adds unit tests