Skip to content

Improve performance of Queues::drain_iter#213

Merged
StackDoubleFlow merged 1 commit intoMCHPR:masterfrom
KonaeAkira:improve-queue-drain-iter
Dec 7, 2025
Merged

Improve performance of Queues::drain_iter#213
StackDoubleFlow merged 1 commit intoMCHPR:masterfrom
KonaeAkira:improve-queue-drain-iter

Conversation

@KonaeAkira
Copy link
Contributor

Checking performance using the benchmark I added in #212 shows that performance has improved when compared to master:

time:   [250.53 µs 251.09 µs 251.69 µs]
change: [-1.8127% -1.3880% -1.0153%] (p = 0.00 < 0.05)
Performance has improved.

Godbolt: https://godbolt.org/z/f8W6v9fdo

@KonaeAkira
Copy link
Contributor Author

The drop behavior of the new implementation is not the same as the old implementation, but that shouldn't matter as the iterator seems to never get dropped half-way.

@StackDoubleFlow StackDoubleFlow merged commit a179ab1 into MCHPR:master Dec 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants