-
-
Notifications
You must be signed in to change notification settings - Fork 447
update sdnext license and branding #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vladimir Mandic <[email protected]>
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vladmandic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the license and branding information for the SD.Next
package within the StabilityMatrix.Core
project. These changes include a shift in the license type from AGPL-3.0 to Apache License 2.0, an updated license URL, a more descriptive blurb, and a new preview image URI. This aligns the package's metadata with recent changes in the sdnext
project, specifically after the removal of a1111
code.
Highlights
- License Update: The
LicenseType
for theSD.Next
package has been updated from 'AGPL-3.0' to 'Apache License 2.0', reflecting a change in the project's licensing. - License URL Change: The
LicenseUrl
has been modified to point to the new license file within thesdnext
repository, aligning with the updated license type. - Branding and Description Update: The
Blurb
(short description) forSD.Next
has been revised to 'SD.Next: All-in-one WebUI for AI generative image and video creation', providing a more comprehensive overview of its functionality. - Preview Image Update: The
PreviewImageUri
has been updated to a new asset URL, likely reflecting a refreshed visual representation for the package.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the license and branding information for the SD.Next package. The changes correctly reflect the new Apache 2.0 license and the updated repository URL. However, I've identified a potential issue with the PreviewImageUri
, which now points to a GitHub user attachment URL. These URLs are not permanent and could lead to a broken image in the user interface. I've added a comment with a recommendation to use a more stable hosting solution for this asset.
public override string LaunchCommand => "launch.py"; | ||
|
||
public override Uri PreviewImageUri => new("https://cdn.lykos.ai/sm/packages/vladautomatic/preview.webp"); | ||
public override Uri PreviewImageUri => new("https://github.com/user-attachments/assets/d6119a63-6ee5-4597-95f6-29ed0701d3b5"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PreviewImageUri
is pointing to a GitHub user attachment URL. These URLs are not guaranteed to be permanent and can break if the associated content (like a comment or issue) is deleted. This could lead to a broken image in the UI. It is recommended to host this asset in a more stable location, such as a CDN or within a repository and link to its raw version, similar to how other package assets are handled.
minor changes to reflect updated sdnext license after removal of a1111 code