Fix false duplicate warning for multiple --log targets - #257
Open
aavdberg wants to merge 1 commit into
Open
Conversation
Fix duplicate flag detection for --log options The addon previously treated all --log=<component>:<level> arguments as duplicates because duplicate detection only considered the flag name before '='. This change uses the log component as part of the duplicate key, allowing configurations such as: --log=all:notice --log=bus:notice without generating false duplicate warnings. Duplicate detection still works for actual duplicates of the same log target, e.g.: --log=bus:notice --log=bus:debug ``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The duplicate flag detection logic only considers the flag name
before the
=character.As a result, configurations like: