Fix HeatJS custom heat source overlapping Blaze Burner in JEI categories#153
Closed
konkentrate wants to merge 3 commits into
Closed
Fix HeatJS custom heat source overlapping Blaze Burner in JEI categories#153konkentrate wants to merge 3 commits into
konkentrate wants to merge 3 commits into
Conversation
Lucreeper74
added a commit
that referenced
this pull request
May 15, 2026
Lucreeper74
added
the
fixed / added in next update ✅
Owner
|
I reject this PR, I just made what HeatJS mixin injection normally do with regular Create categories classes to prevent unexpected behavior in the future. This also allow to use independent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recipe had a custom HeatJS heat source, the Blaze Burner was still being drawn on top of it in the Melting and Alloying JEI categories.
CategoryHelper.drawCustomHeatSource already returns a boolean for exactly this case, but the return value was never used. Added a customHeatSource flag to FoundryBasinCategory to track it, skip the Blaze Burner draw in the subclasses when a custom source is already rendered.