fix(hip): dflash compatibility aliases + TQ3_0 FA guard#8
Merged
davide221 merged 2 commits intoLuce-Org:luce-dflashfrom May 8, 2026
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luce-dflashbranch under-DGGML_HIP=ONfor downstream dflash builds (Strix Halo / gfx1151, ROCm 7.2 / clang 21).Changes
ggml/src/ggml-cuda/vendors/hip.h— add four missing CUDA→HIP symbol aliases that newer dflash code paths depend on:cublasSgemmStridedBatched→hipblasSgemmStridedBatchedcudaStreamCaptureStatus→hipStreamCaptureStatuscudaStreamCaptureStatusNone→hipStreamCaptureStatusNonecudaStreamIsCapturing→hipStreamIsCapturingggml/src/ggml-cuda/gated_delta_net.cu— guard the<cuda_fp16.h>include under#ifndef GGML_USE_HIP(HIP path picks up the type viahip_fp16.hthrough the runtime header).ggml/src/ggml-cuda/fattn.cu— wrap theTQ3_0FATTN_VEC_CASES_ALL_Dtemplate instantiations under#ifndef GGML_USE_HIP. The TQ3_0vec_dotkernel isn't ported to HIP yet, so instantiating these on HIP fails to link.Why
Without these, a HIP build of
luce-dflashfails atggml-hipwith errors like:'cuda_fp16.h' file not found(gated_delta_net.cu)use of undeclared identifier 'cublasSgemmStridedBatched'/'cudaStreamCaptureStatus'(fattn-chunked.cu)Test plan
-DGGML_HIP=ON -DCMAKE_HIP_ARCHITECTURES=gfx1151