-
Notifications
You must be signed in to change notification settings - Fork 10
Expose uri params label message #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Expose uri params label message #50
Conversation
|
it'd make sense to merge this first #51 |
29231ab to
c49a838
Compare
|
Ok this has been rebased an is ready for merge now I believe @DanGould unfortunately one of the deps updates somehow slipped through the other pr and so the change to fix the RFB version to 2.0.0 is in this PR. I know that I was having an issue with the non-specific version for RFB so I fixed it and everything works for me with this change |
|
Exposing label and message seems right. As noted in the past PR your commit messages must adhere to a certain standard. Are you sure the first commit is right? Wouldn't a change to deps update podspec.lock, or is it already using 2.0.0? The first commit message says 'sever' instead of 'severe' as well. perhaps "Make RFB version fixed to avoid v conflicts" > "Fix FRB version to avoid conflilcts"? |
|
I'm going to retest that dep fixing, probably unnecessary. I think I actually reverted in when I split the PR in two. I'm also going to update the payjoin_ffi version to the release |
|
No reason to tag since we won't do an 0.22.1 release, and bull bitcoin isn't using proper releases anyhow, and they'll upgrade to 0.23. Just use the commit hash so we can progress |
|
using the following to test locally: |
c49a838 to
e679318
Compare
|
ok should be good to go |
Exposing these params means that the lib will expose full bip21 uri parsing Many apps have custom bip21 logic, this eliminates the need for that
e679318 to
7e1e320
Compare
|
ok I removed the readme updates, but this is something I find myself looking up every time I run the app so I'd like it to be in here Simulator is the xcode simulator app. you have to have an instance already running for flutter to see it as a deploy target |
|
@DanGould ready to merge? Once merged this is up to date with the bb dep so this repo can be upgraded with persistence and that can be added to bb next |
Closes #48
We want to expose standard bip21 params on the Uri type so that it can be used as a bip21 module in apps.
Note that this pr points to an updated version of payjoin-ffi that exposes the params (label + message).
The dependency on payjoin-ffi has been updated to point to the main payjoin-ffi repo
Note: locally I had to make some other changes just to get the example running, they are included in a separate commit that should not be merged