Warn when scheduled WattPlan tasks are disabled#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #35.
This was detected from review of #29.
Tests
WATTPLAN_TEST_VENV=/tmp/wattplan-venv-shared ./scripts/run_tests.sh tests/integration/test_config_flow.py -qWATTPLAN_TEST_VENV=/tmp/wattplan-venv-shared ./scripts/run_tests.shpython -m json.tool custom_components/wattplan/strings.jsonpython -m json.tool custom_components/wattplan/translations/en.jsongit diff --checkScreenshots
Skipped. I attempted to boot Home Assistant from
/tmp/wattplan-issue35-ha-config; the first run hit an occupied8123port and missingdefault_configdependencies in the shared test venv. A minimal config did boot on port8135, but completing frontend onboarding/auth and creating enough UI state for options-flow screenshots was too brittle for the stretch goal.