Restore missing 'ld' pin for RAM in Separate Ports mode#47
Open
KEDIT2007 wants to merge 1 commit into
Open
Conversation
This commit fixes a regression introduced in version 2.16.1.4 where the 'ld' (load) pin would disappear when the RAM component was configured with "Separate load and store ports." The issue was caused by moving the OE (Output Enable) pin initialization inside an 'if (!separate)' conditional block in Ram.java. While OE serves as a tri-state enable in combined mode, it is required as the dedicated 'ld' trigger when ports are separated. Moving the pin instantiation outside of the conditional block ensures that the pin is correctly drawn and evaluated in both data interface modes, restoring the intended behavior of the component. Fixes Logisim-Ita#46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #46
Description of Changes
This PR restores the
ld(load) pin on the RAM component when the "Data Interface" attribute is set to "Separate load and store ports".In version 2.16.1.4 (during the introduction of "Simplified Mode"), the logic to initialize and draw the
OE(Output Enable) pin inRam.javawas moved inside a conditional block that only executes if ports are NOT separate (if (!separate)).However, in "Separate Ports" mode, the
OEpin is semantically required to function as theldtrigger. This PR moves theOEpin initialization outside of that conditional block so that it is available in both "One synchronous load/store port" and "Separate load and store ports" modes.