Cargo Hold Tracker: Restore Deposit-All Tracking#240
Open
BBeeaarr wants to merge 2 commits intoLlemonDuck:mainfrom
Open
Cargo Hold Tracker: Restore Deposit-All Tracking#240BBeeaarr wants to merge 2 commits intoLlemonDuck:mainfrom
BBeeaarr wants to merge 2 commits intoLlemonDuck:mainfrom
Conversation
BBeeaarr
commented
Mar 31, 2026
| private static final int SFX_DEPOSIT_ALL_ID = 10905; | ||
| private static final int DEPOSIT_ALL_MAX_TICKS_TIMEOUT = 12; | ||
| private int depositAllTicksRemaining; | ||
| private Multiset<Integer> initialDepositAllInventory; |
Author
There was a problem hiding this comment.
Might be able to use memoizedInventory instead here
BBeeaarr
commented
Mar 31, 2026
| private int previousSfxVolume = -1; | ||
| private static final int SFX_OVERRIDE_VOLUME = 1; | ||
| private static final int SFX_DEPOSIT_ALL_ID = 10905; | ||
| private static final int DEPOSIT_ALL_MAX_TICKS_TIMEOUT = 12; |
Author
There was a problem hiding this comment.
12 ticks gives ~5 seconds for the deposit to occur. Can adjust if necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177
onSoundEffectPlayedevent as the source of truth for the confirmation of a successful quick-depositconsumemethod to avoid playing SFX for players who play with 0 volumeDeposit-allunmute the client anticipating SFX with ID = 10905 and memoize player inventoryDeposit-alland the deposit action