Skip to content

Conversation

@amarshall
Copy link

Description

Previously, would create apps.json if it does not exist before loading the config for the path it should be at. So it was always created at the default location. This is unnecessary but also confusing as an unused file is created and exists.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Previously, would create `apps.json` if it does not exist *before*
loading the config for the path it should be at. So it was always
created at the default location. This is unnecessary but also confusing
as an unused file is created and exists.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@codecov
Copy link

codecov bot commented Jan 8, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.29%. Comparing base (c9e0bb8) to head (47cfd82).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/config.cpp 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4568      +/-   ##
==========================================
- Coverage   15.38%   13.29%   -2.10%     
==========================================
  Files          92       92              
  Lines       18993    17690    -1303     
  Branches     8769     8185     -584     
==========================================
- Hits         2923     2352     -571     
+ Misses      14938    14500     -438     
+ Partials     1132      838     -294     
Flag Coverage Δ
Archlinux 11.54% <0.00%> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 ?
Homebrew-ubuntu-22.04 13.83% <0.00%> (ø)
Linux-AppImage ?
Windows-AMD64 13.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 0.00% <0.00%> (-3.04%) ⬇️

... and 55 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants