Gmoccapy: Fix arrow key up/down bug in tooleditor #3512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
But with this fix, this handy function wouldn't work any longer:
|
|
Not sure I like it much. |
|
Also when you hit enter to finish the edit it automatically goes into editing the cell below. |
|
What we could possibly do is retain the 'Tab' key function so we can go on editing the cell to right. |
|
Tab key enabled:
|
|
I like Sigmas solution with the Tab key ;-) |
|
Demo with Tab and Esc keys: |
|
I'll put the Tab and Esc key feature in a separate PR against master as it is not a bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key_press handler inside 'tooledit_widget.py' interferes when using the arrow up/down keys (one keypress results in moving two rows ):
New (fixed) behavior:
