Skip to content

debian: lintian indicates hardening-no-relro: panelui, module_helper #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2025

Conversation

smoe
Copy link
Contributor

@smoe smoe commented Apr 14, 2025

I wish there was a comment for panelui if the LDFLAGS were intentionally omitted.

We have no policy about the use of "@" (don't show the command) in Makefiles. I removed the one for the compilation of linuxcnc_module_helper since arguments to the compiler ar eimportant to know. Was tempted to introduce it for all the $(ECHO) instructions, though, since we have little incentive to read the same lines twice.

@smoe
Copy link
Contributor Author

smoe commented Apr 14, 2025

The warnings were observed on
https://udd.debian.org/lintian/?packages=linuxcnc

@smoe
Copy link
Contributor Author

smoe commented Apr 14, 2025

Hm. Seems like I was addressing panelui before at #3381,
albeit slightly differently.

I cannot confirm myself if panelui and linuxcnc_module_helper are indeed functional with the the -z relro added. If some good soul that is using those binaries could please confirm that for me and then this should go into the 2.9 branch, not against master. I would then also go and rebase what I did in #3381 accordingly.

@andypugh
Copy link
Collaborator

I think that panelui is something @c-morley wrote?
There seems to be a sample config to test it with:
sim/axis/panelui-demo

@smoe
Copy link
Contributor Author

smoe commented Apr 18, 2025

Just started the panelui demo and experienced no crashes. Seems like fine.
Lintian complained about lines too long in d/changelog and typos that I addressed (all typos, not all long lines).
Edited lintian overrides to eliminate some more warnings..

@smoe
Copy link
Contributor Author

smoe commented Apr 25, 2025

The build was cancelled. Did not break or anything. I think this can go in.

@BsAtHome
Copy link
Contributor

The build was cancelled. Did not break or anything. I think this can go in.

See #3408.

@smoe
Copy link
Contributor Author

smoe commented May 20, 2025

Have seen that #3388 was merged, will rebase to the latest 2.9 later tonight, which should then also fix the build.

@andypugh
Copy link
Collaborator

andypugh commented Jul 9, 2025

Is this still live?

@smoe
Copy link
Contributor Author

smoe commented Jul 9, 2025

Thank you for your reminder.

@smoe smoe force-pushed the lintian_missing_relro branch from 2feb2f9 to 8c4859c Compare July 11, 2025 23:37
@smoe
Copy link
Contributor Author

smoe commented Jul 18, 2025

@andypugh , I just skimmed through the changes again and think this is fine. Should also be good to find its way to 2.10.

@smoe
Copy link
Contributor Author

smoe commented Jul 18, 2025

That said, should I squash those patches?

@andypugh
Copy link
Collaborator

That said, should I squash those patches?

I can squash on merge.

@andypugh andypugh merged commit 71d48c3 into LinuxCNC:2.9 Jul 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants