-
Notifications
You must be signed in to change notification settings - Fork 1.2k
debian: lintian indicates hardening-no-relro: panelui, module_helper #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The warnings were observed on |
Hm. Seems like I was addressing panelui before at #3381, I cannot confirm myself if panelui and linuxcnc_module_helper are indeed functional with the the -z relro added. If some good soul that is using those binaries could please confirm that for me and then this should go into the 2.9 branch, not against master. I would then also go and rebase what I did in #3381 accordingly. |
I think that panelui is something @c-morley wrote? |
Just started the panelui demo and experienced no crashes. Seems like fine. |
The build was cancelled. Did not break or anything. I think this can go in. |
See #3408. |
Have seen that #3388 was merged, will rebase to the latest 2.9 later tonight, which should then also fix the build. |
Is this still live? |
Thank you for your reminder. |
2feb2f9
to
8c4859c
Compare
@andypugh , I just skimmed through the changes again and think this is fine. Should also be good to find its way to 2.10. |
That said, should I squash those patches? |
I can squash on merge. |
I wish there was a comment for panelui if the LDFLAGS were intentionally omitted.
We have no policy about the use of "@" (don't show the command) in Makefiles. I removed the one for the compilation of linuxcnc_module_helper since arguments to the compiler ar eimportant to know. Was tempted to introduce it for all the $(ECHO) instructions, though, since we have little incentive to read the same lines twice.