Skip to content

Fixes CVE-2021-44228 WIZ scan violation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fixes CVE-2021-44228 WIZ scan violation #65

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae5e9cc
Fixes CVE-2021-44228 WIZ scan violation breaking corporate applicatio…
SomethingNew71 May 15, 2025
88eb3aa
Updates version number
SomethingNew71 May 15, 2025
4381370
Fixes secondary dependency noted by windsurf AI
SomethingNew71 May 16, 2025
0e855a0
Reverts package.json
SomethingNew71 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {
mavenCentral()
google()
}
def buildGradleVersion = ext.has('buildGradlePluginVersion') ? ext.get('buildGradlePluginVersion') : '4.2.2'
def buildGradleVersion = ext.has('buildGradlePluginVersion') ? ext.get('buildGradlePluginVersion') : '7.3.3'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that upgrading the gradle version will not make some dependency not working
think we should relainch the project

Copy link
Author

@SomethingNew71 SomethingNew71 May 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure to be honest. I am not a android dev I was just following the suggestion by WIZ to resolve it. Was hoping someone more experienced with gradle and android development to review and help out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will try to check it later
but am sure if the maintainer is still maintaining the project
@LinusU are you still up to validate PRs, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glc-ineddar @LinusU I just pushed a second update based on some AI suggestions I got from Windsurf. According to this, that's the only thing required to ensure its working properly


dependencies {
classpath "com.android.tools.build:gradle:$buildGradleVersion"
Expand All @@ -27,7 +27,7 @@ android {
namespace 'org.linusu'
}
compileSdkVersion safeExtGet('compileSdkVersion', 30)
buildToolsVersion safeExtGet('buildToolsVersion', '30.0.3')
buildToolsVersion safeExtGet('buildToolsVersion', '33.0.0')

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 16)
Expand Down