-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Set _DeviceDtypeModuleMixin
_device from torch's default device function
#21164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set _DeviceDtypeModuleMixin
_device from torch's default device function
#21164
Conversation
since the change is with Fabric lets add slo relevant test to fabric |
Co-authored-by: Bhimraj Yadav <[email protected]>
Will look into the other failing tests shortly. |
…and_dtype is finished.
…into fix/trainer_init_module_device
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21164 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 269 269
Lines 23656 23657 +1
=======================================
+ Hits 20633 20634 +1
Misses 3023 3023 |
@bhimrazy mind review again, pls :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes #20307
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21164.org.readthedocs.build/en/21164/