Skip to content

Conversation

@ChristianPervoelz
Copy link

PR contains a bunch of Idle animations for dresses, armor, necklaces and charms.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for liberatedpixelcup ready!

Name Link
🔨 Latest commit c84fa3a
🔍 Latest deploy log https://app.netlify.com/projects/liberatedpixelcup/deploys/693127cae9887b0008df56f6
😎 Deploy Preview https://deploy-preview-270--liberatedpixelcup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jrconway3
Copy link
Contributor

jrconway3 commented Dec 3, 2025

This relates to:
jrconway3#51

I'll check them out, but there's no json file updates. All assets getting a new animation need to have those animation(s) added to the json as well.

Another consideration, it might be better to wait for:
#230

To be completed before we start adding tons of more recolors. I have started going back to some things, but am waiting for this before I add any new PR's in hopes that update can be finished.

For Idles, Frame 1 is basically identical to the base frame of most of the base assets, like walk.

Frame 2 is where some shifts might happen depending on a given situation. Either pants or shirts need to be stretched a bit. Most assets are fine just being bumped up by 1px though.

@jrconway3
Copy link
Contributor

So as it turns out, I had the Idles for Kimono lying around. Not a big deal, though, its only one extra frame really. I never added them because at the time I finished them I hadn't started working on expanded frames yet.

Animations section was added to all affected sheet definitions to cover the idle animation.
@ChristianPervoelz
Copy link
Author

ChristianPervoelz commented Dec 4, 2025

Thanks for the reminder about the json files - totally forgot the animations section in sheet definitions. For my local purposes I just modified item-metadata and source-index. Files are included now. Btw: may it is possible to avoid the animation sections completely, e.g. by parsing the directories for available animations, which would make it way easier to add animations.

Shall I remove the kimono parts then, so you could use yours and we avoid collisions and nasty merges?

About Idles: Yes, Idles are the easiest. All the files in this PR were created in an automated way with some manual rework for stretches where required (e.g. bodices). That's why there are so many files. Doing that completely manually would be insane.

On PR #230: Yes, maybe it's better to wait. On the other hand, that PR has a long way to go, as there are still many question to be answered and the code itself has still some bugs, e.g. I tested it in 4 different browsers: MS-Edge: good, Chrome: Only the headline displayed, Opera: Good, but crashing sometimes, Firefox: sometimes only the headline visible, sometimes good, sometimes crashing, sometimes blocking everything

@jrconway3
Copy link
Contributor

Its not a big deal. If yours look about the same as mine I don't have to deploy mine and simply work on additional assets. I started working on Kimono Emote now.

Yes, I'm aware it will take some time for that other PR to finish. Still, adding extra recolors just means more stuff in the repo history. I guess its not a big deal, but I should still review these just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants