-
Notifications
You must be signed in to change notification settings - Fork 433
Some idle animations #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Some idle animations #270
Conversation
✅ Deploy Preview for liberatedpixelcup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This relates to: I'll check them out, but there's no json file updates. All assets getting a new animation need to have those animation(s) added to the json as well. Another consideration, it might be better to wait for: To be completed before we start adding tons of more recolors. I have started going back to some things, but am waiting for this before I add any new PR's in hopes that update can be finished. For Idles, Frame 1 is basically identical to the base frame of most of the base assets, like walk. Frame 2 is where some shifts might happen depending on a given situation. Either pants or shirts need to be stretched a bit. Most assets are fine just being bumped up by 1px though. |
|
So as it turns out, I had the Idles for Kimono lying around. Not a big deal, though, its only one extra frame really. I never added them because at the time I finished them I hadn't started working on expanded frames yet. |
Animations section was added to all affected sheet definitions to cover the idle animation.
|
Thanks for the reminder about the json files - totally forgot the animations section in sheet definitions. For my local purposes I just modified Shall I remove the kimono parts then, so you could use yours and we avoid collisions and nasty merges? About Idles: Yes, Idles are the easiest. All the files in this PR were created in an automated way with some manual rework for stretches where required (e.g. bodices). That's why there are so many files. Doing that completely manually would be insane. On PR #230: Yes, maybe it's better to wait. On the other hand, that PR has a long way to go, as there are still many question to be answered and the code itself has still some bugs, e.g. I tested it in 4 different browsers: MS-Edge: good, Chrome: Only the headline displayed, Opera: Good, but crashing sometimes, Firefox: sometimes only the headline visible, sometimes good, sometimes crashing, sometimes blocking everything |
|
Its not a big deal. If yours look about the same as mine I don't have to deploy mine and simply work on additional assets. I started working on Kimono Emote now. Yes, I'm aware it will take some time for that other PR to finish. Still, adding extra recolors just means more stuff in the repo history. I guess its not a big deal, but I should still review these just in case. |
PR contains a bunch of Idle animations for dresses, armor, necklaces and charms.