Fix rope support logic for tomato crops - #60
Open
Spyrauks wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When the tomato crop reaches its maximum height, the rope above it breaks but the rope attached to the crop is not affected. I do not know if this was an intented feature so as to make the rope a temporary support. I think it's more realistic for the rope to stay permanently. In any case, it does not make sense for the rope to just stand there without being attached to a support.
Fix
The canSurvive method of the TomatoCropHead class returned false when the block below the head was a TomatoCropBody which means that a TomatoCropHead block breaks as soon as he appears so I simply changed the boolean logic of the method so that a TomatoCropHead stays intact when it appears.