feat(product-console): update image tag to 1.5.0#1160
feat(product-console): update image tag to 1.5.0#1160ferr3ira-gabriel merged 1 commit intodevelopfrom
Conversation
WalkthroughUpdated Changes
sequenceDiagram
rect rgba(200,220,255,0.5)
participant User
participant Helm as Helm Chart
participant KubeAPI as Kube API
participant Pod as ProductConsole Pod
participant Node as Kubernetes Node
participant OTEL as OTEL Collector
end
User->>Helm: helm upgrade/install (with otel.external=true)
Helm->>KubeAPI: apply Pod spec with injected env (OTEL_* or HOST_IP)
KubeAPI->>Node: schedule Pod
Node->>Pod: provide status.hostIP (HOST_IP)
Pod->>OTEL: send metrics/traces/logs to configured OTEL endpoint
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Comment |
b7aa28c to
27ab515
Compare
- Update image tag from 1.3.0 to 1.5.0 - Update appVersion to 1.5.0 - Add UPGRADE-2.0.md documentation for v2.0 migration Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/product-console/docs/UPGRADE-2.0.md`:
- Around line 190-191: Update the documentation so the OTEL env var injection
condition matches the template: state that OTEL URL env vars are injected when
either otel.enabled=true or otel.external=true (not only otel.external=true),
and adjust the example setting (the "external: false" line or surrounding
explanatory sentence) to reflect this dual-condition behavior; ensure mentions
of OTEL env injection elsewhere (the second instance referencing otel.external)
are similarly updated to reference both otel.enabled and otel.external.
In `@charts/product-console/values.yaml`:
- Line 17: The image tag in values.yaml (image.tag: "1.5.0") is inconsistent
with Chart.yaml's appVersion (1.3.0); update one to match the other. Open
Chart.yaml and either bump appVersion to "1.5.0" to match values.yaml, or change
values.yaml's image.tag to "1.3.0" so both files agree; ensure you update
whichever symbol you change (appVersion in Chart.yaml or image.tag in
values.yaml) and run a quick lint/install to verify the chart metadata and
deployed image version are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8f02ebf5-b50d-4a0d-8bd1-358f90c4ed6b
📒 Files selected for processing (2)
charts/product-console/docs/UPGRADE-2.0.mdcharts/product-console/values.yaml
| # When true, deployment will inject OTEL_URL_* environment variables | ||
| external: false |
There was a problem hiding this comment.
Broaden OTEL env injection condition in docs to match template behavior.
Line 190 and Line 209 describe env injection as tied only to otel.external=true, but the template injects OTEL env vars when either otel.enabled=true or otel.external=true. This is a documentation mismatch.
✏️ Proposed doc fix
- # When true, deployment will inject OTEL_URL_* environment variables
+ # When otel.enabled=true or otel.external=true, deployment injects OTEL_URL_* environment variables
external: false-### Injected environment variables (when otel.external=true)
+### Injected environment variables (when otel.enabled=true or otel.external=true)Also applies to: 209-210
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@charts/product-console/docs/UPGRADE-2.0.md` around lines 190 - 191, Update
the documentation so the OTEL env var injection condition matches the template:
state that OTEL URL env vars are injected when either otel.enabled=true or
otel.external=true (not only otel.external=true), and adjust the example setting
(the "external: false" line or surrounding explanatory sentence) to reflect this
dual-condition behavior; ensure mentions of OTEL env injection elsewhere (the
second instance referencing otel.external) are similarly updated to reference
both otel.enabled and otel.external.
27ab515 to
a289f8c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
charts/product-console/docs/UPGRADE-2.0.md (1)
49-50:⚠️ Potential issue | 🟡 MinorDocs still understate OTEL env injection condition.
These sections say injection happens only with
otel.external=true, but template logic injects env vars when eitherotel.enabled=trueorotel.external=true. Please align wording in all three spots.✏️ Suggested doc patch
-When `otel.external=true` and no static host is provided, the chart injects the pod's host IP dynamically: +When `otel.enabled=true` or `otel.external=true` and no static host is provided, the chart injects the pod's host IP dynamically:- # When true, deployment will inject OTEL_URL_* environment variables + # When otel.enabled=true or otel.external=true, deployment injects OTEL_URL_* environment variables-### Injected environment variables (when otel.external=true) +### Injected environment variables (when otel.enabled=true or otel.external=true)Also applies to: 190-191, 209-210
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/product-console/docs/UPGRADE-2.0.md` around lines 49 - 50, Update the wording in the three documented spots that currently state "When `otel.external=true` ..." to reflect the actual template logic: state that env var injection happens when either `otel.enabled=true` OR `otel.external=true`; search for occurrences referencing `otel.external=true` in the UPGRADE-2.0.md text and replace the phrasing so it explicitly mentions both `otel.enabled` and `otel.external` as the OR condition, ensuring all three occurrences are changed consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/product-console/docs/UPGRADE-2.0.md`:
- Around line 223-224: The upgrade docs show a hardcoded flag "--version 2.0.0"
that mismatches the chart's actual version in Chart.yaml ("2.0.0-beta.2");
update the example(s) to either use the exact published chart version
"2.0.0-beta.2" or change to a placeholder like "--version <chart-version>" so
they stay correct; replace every occurrence of "--version 2.0.0" in the
UPGRADE-2.0.md file (including the other instance later in the file) to keep
examples consistent with Chart.yaml.
---
Duplicate comments:
In `@charts/product-console/docs/UPGRADE-2.0.md`:
- Around line 49-50: Update the wording in the three documented spots that
currently state "When `otel.external=true` ..." to reflect the actual template
logic: state that env var injection happens when either `otel.enabled=true` OR
`otel.external=true`; search for occurrences referencing `otel.external=true` in
the UPGRADE-2.0.md text and replace the phrasing so it explicitly mentions both
`otel.enabled` and `otel.external` as the OR condition, ensuring all three
occurrences are changed consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7a5cf928-10f4-4f81-b342-0b791dceee5a
📒 Files selected for processing (3)
charts/product-console/Chart.yamlcharts/product-console/docs/UPGRADE-2.0.mdcharts/product-console/values.yaml
| --version 2.0.0 \ | ||
| -n product-console |
There was a problem hiding this comment.
Upgrade command version likely mismatches currently published chart artifact.
The examples use --version 2.0.0, while Chart.yaml is 2.0.0-beta.2 in this PR. This can mislead users during rollout testing.
✏️ Suggested doc patch
- --version 2.0.0 \
+ --version 2.0.0-beta.2 \Also applies to: 231-232
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@charts/product-console/docs/UPGRADE-2.0.md` around lines 223 - 224, The
upgrade docs show a hardcoded flag "--version 2.0.0" that mismatches the chart's
actual version in Chart.yaml ("2.0.0-beta.2"); update the example(s) to either
use the exact published chart version "2.0.0-beta.2" or change to a placeholder
like "--version <chart-version>" so they stay correct; replace every occurrence
of "--version 2.0.0" in the UPGRADE-2.0.md file (including the other instance
later in the file) to keep examples consistent with Chart.yaml.
Summary
Updates product-console image tag from 1.3.0 to 1.5.0.
Changes
1.3.0→1.5.0Notes