fix(plugin-access-manager): clean dead OTEL defaults and fix SWAGGER_HOST service names#1158
Merged
guimoreirar merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
- Remove stale midaz-grafana.midaz.svc.cluster.local:4317 defaults from OTEL_EXPORTER_OTLP_ENDPOINT in plugin-access-manager (auth + identity) and plugin-fees configmap templates. The deployment templates already inject OTEL_EXPORTER_OTLP_ENDPOINT via HOST_IP:4317, making these configmap defaults dead config. - Fix SWAGGER_HOST defaults in plugin-access-manager configmap templates: - auth: plugin-auth -> plugin-access-manager-auth - identity: plugin-identity -> plugin-access-manager-identity Part of DSINT-1009.
WalkthroughKubernetes ConfigMap templates in three plugin charts updated their environment variable defaults. The Changes
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/plugin-access-manager/templates/auth/configmap.yaml`:
- Line 37: The SWAGGER_HOST default hardcodes "plugin-access-manager-auth"
causing drift from the Service name; update the default for
.Values.auth.configmap.SWAGGER_HOST to derive from the same fullname helper used
for the Service by using include "plugin-auth.fullname" (pass the current
context) and append the cluster DNS suffix so SWAGGER_HOST is built from the
helper output rather than a hardcoded string; adjust the SWAGGER_HOST line that
references .Values.auth.configmap.SWAGGER_HOST accordingly.
In `@charts/plugin-access-manager/templates/identity/configmap.yaml`:
- Line 33: The SWAGGER_HOST default is hardcoded to
"plugin-access-manager-identity" causing name drift; update the default to use
the same helper that generates the Service/ConfigMap name by calling the chart
template include "plugin-identity.fullname" (pass the current context) as the
host base instead of the literal string, keeping port and cluster domain suffix
and leaving Values.identity.configmap.SWAGGER_HOST override behavior intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 55015847-732e-4216-a301-9c6adf5add9b
📒 Files selected for processing (3)
charts/plugin-access-manager/templates/auth/configmap.yamlcharts/plugin-access-manager/templates/identity/configmap.yamlcharts/plugin-fees/templates/fees/configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleans up dead config and fixes stale service name references in configmap templates.
Changes
OTEL_EXPORTER_OTLP_ENDPOINT default → empty (3 templates)
plugin-access-manager/auth/configmap.yamlplugin-access-manager/identity/configmap.yamlplugin-fees/fees/configmap.yamlThe old default (
midaz-grafana.midaz.svc.cluster.local:4317) referenced a non-existent service. The deployment templates already inject this env var viaHOST_IP:4317(DaemonSet hostPort), so the configmap value is never used. Setting to empty eliminates the misleading reference.SWAGGER_HOST default → correct service name (2 templates)
plugin-access-manager/auth/configmap.yaml:plugin-auth→plugin-access-manager-authplugin-access-manager/identity/configmap.yaml:plugin-identity→plugin-access-manager-identityThese still used pre-rename service names from when the services were called
plugin-authandplugin-identity.Context
Part of DSINT-1009 — GitOps Cross-Reference Audit.