Skip to content

Shosh file module updates#94

Merged
shoshannaTM merged 8 commits into
masterfrom
shosh-file-module-updates
Jan 14, 2026
Merged

Shosh file module updates#94
shoshannaTM merged 8 commits into
masterfrom
shosh-file-module-updates

Conversation

@shoshannaTM

Copy link
Copy Markdown
Collaborator

No description provided.

@shoshannaTM
shoshannaTM requested a review from gianlazz January 10, 2026 00:28
Comment thread .vscode/settings.json Outdated
Comment thread package.json Outdated
@gianlazz

Copy link
Copy Markdown
Member

Let's remove these unused imports I found from running ./scripts/preCommit.sh

/Users/gianlazzarini/Development/Lazztech.Hub-Service/src/file/file-service.abstract.ts
3:15 warning 'Response' is defined but never used @typescript-eslint/no-unused-vars
10:10 warning 'ReadStream' is defined but never used @typescript-eslint/no-unused-vars

/Users/gianlazzarini/Development/Lazztech.Hub-Service/src/file/local-file/local-file.service.ts
1:49 warning 'Logger' is defined but never used @typescript-eslint/no-unused-vars

/Users/gianlazzarini/Development/Lazztech.Hub-Service/src/file/s3-file/s3-file.service.ts
32:18 warning 'fileStream' is defined but never used @typescript-eslint/no-unused-vars

/Users/gianlazzarini/Development/Lazztech.Hub-Service/src/hub/hub-activity/hub-activity.service.spec.ts
17:7 warning 'hubRepo' is assigned a value but never used @typescript-eslint/no-unused-vars

/Users/gianlazzarini/Development/Lazztech.Hub-Service/src/sentry/sentry.plugin.ts
2:54 warning 'GraphQLRequestContext' is defined but never used @typescript-eslint/no-unused-vars

@gianlazz

gianlazz commented Jan 14, 2026

Copy link
Copy Markdown
Member

Let's replace any instance of from 'uuid'; imports and usage with import { randomUUID } from 'crypto';. I see a couple remaining.

Lazztech.Hub-Service/src/event/event.service.ts
Lazztech.Hub-Service/src/hub/hub.service.ts

Then we should be able to remove @types/uuid from the package.json's devDependencies.

@gianlazz

Copy link
Copy Markdown
Member

I see src/hub/hub.service.spec.ts is still importing import { FileServiceInterface } from '../file/interfaces/file-service.interface'; let's switch that to the new file service abstract.

@gianlazz gianlazz closed this Jan 14, 2026
@gianlazz gianlazz reopened this Jan 14, 2026
@gianlazz

Copy link
Copy Markdown
Member

Let's remove src/file/file-service.token.ts since it's not used anymore.

Comment thread src/file/controller/file.controller.spec.ts

@gianlazz gianlazz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is a big PR which was expected but there's a lot to get through. Let's get the commented changes resolved and I'll give it another look over.

Comment thread src/file/local-file/local-file.service.spec.ts
Comment thread src/file/s3-file/s3-file.service.ts Outdated
Comment thread src/file/s3-file/s3-file.service.ts
Comment thread .vscode/settings.json Outdated
@shoshannaTM
shoshannaTM merged commit e906171 into master Jan 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants