New Accessible Dropdown Nav Bar Component #478
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| & { | ||
|
There was a problem hiding this comment. I haven't seen this usage before! What does |
||
| .dropdown-nav-menu { | ||
| display: none; | ||
|
|
||
| @include media($tablet) { | ||
| display: block; | ||
| } | ||
|
|
||
| .menu-item { | ||
| margin-top: 30px; | ||
| cursor: pointer; | ||
| font-size: 20px; | ||
| text-align: left; | ||
| width: inherit; | ||
|
|
||
| @include media($tablet) { | ||
| display: inline-block; | ||
| margin: 0; | ||
| margin-right: 30px; | ||
| } | ||
|
|
||
| a { | ||
| @include rem(font-size, 20px); | ||
|
|
||
| @include media($tablet) { | ||
| @include s-base; | ||
| } | ||
| } | ||
|
|
||
| /* Show the dropdown menu on hover (except on mobile) or triggered by keyboard/touch */ | ||
| &:hover { | ||
| .sub-menu { | ||
| @include media($tablet) { | ||
| display: block; | ||
| } | ||
| } | ||
| } | ||
| &.open-submenu { | ||
| .sub-menu { | ||
| display: block; | ||
| } | ||
| } | ||
|
|
||
| .menu-item-button { | ||
| display: inline-block; | ||
| padding: 0 18px; | ||
| vertical-align: top; | ||
| background: none; | ||
| width: auto; | ||
| border: none; | ||
|
|
||
| &:after { | ||
| content: 'v'; | ||
| display: inline-block; | ||
| font-size: 20px; | ||
| } | ||
|
|
||
| @include media($tablet) { | ||
| display: none; | ||
| vertical-align: initial; | ||
|
|
||
| &.desktop-visible, | ||
| &:focus { | ||
| display: inline-block; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .sub-menu { | ||
| display: none; | ||
| padding: 10px 0 20px; | ||
|
|
||
| @include media($tablet) { | ||
| position: absolute; | ||
| background-color: $white-base; | ||
| padding: 5px 15px; | ||
| } | ||
|
|
||
| .menu-item { | ||
| padding: 0; | ||
| margin-top: 15px; | ||
| display: block; | ||
|
|
||
| @include media($tablet) { | ||
| padding-bottom: 20px; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| $tablet: new-breakpoint(min-width 0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| .dropdown-nav-bar.no-mobile { | ||
| @import 'dropdown-nav-bar-no-mobile'; | ||
| @import 'dropdown-nav-bar-common'; | ||
| } | ||
|
|
||
| .dropdown-nav-bar:not(.no-mobile) { | ||
| @import 'dropdown-nav-bar-common'; | ||
| } | ||
|
Comment on lines
+1
to
+8
There was a problem hiding this comment. This allowed me to use the same styles for both implementations and just change the There was a problem hiding this comment. Interesting! I'll defer to @marchwiany on best practices in using dynamic variables as this is pretty foreign to me. For my own edification, would the following not perform a similarly sequenced import? Maybe in the compilation step the second block is executed before the first? .dropdown-nav-bar.no-mobile {
@import 'dropdown-nav-bar-no-mobile';
}
.dropdown-nav-bar {
@import 'dropdown-nav-bar-common';
} |
||
|
|
||
| #mobile-nav-button { | ||
| position: absolute; | ||
| top: -9999px; | ||
| left: -9999px; | ||
|
|
||
| &:checked { | ||
| & ~ .dropdown-nav-bar .dropdown-nav-menu { | ||
| top: 0; | ||
| position: fixed; | ||
| overflow: auto; | ||
| display: block; | ||
| height: 100%; | ||
| width: 100%; | ||
| } | ||
|
|
||
| & ~ .mobile-menu { | ||
| span:nth-child(1) { | ||
| transform: translateY(8px) rotate(45deg); | ||
| } | ||
| span:nth-child(2) { | ||
| opacity: 0; | ||
| } | ||
| span:nth-child(3) { | ||
| transform: translateY(-8px) rotate(-45deg); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .mobile-menu { | ||
| position: absolute; | ||
| right: 15px; | ||
| z-index: 3; | ||
| cursor: pointer; | ||
|
|
||
| @include media($tablet) { | ||
| display: none; | ||
| } | ||
|
|
||
| span { | ||
| display: block; | ||
| margin: 4px auto; | ||
| height: 4px; | ||
| width: 25px; | ||
| background: #333; | ||
| transition: 0.5s; | ||
| } | ||
| } | ||
|
Comment on lines
+10
to
+57
There was a problem hiding this comment. What's the distinction between these styles and the ones included in |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this need to be ported over to the client template as well or will the styles automatically be applied when a user imports the component into their project?