Skip to content

chore(deps): Bump hmac from 0.12.1 to 0.13.0 in /apps/helper/src-tauri#1083

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/apps/helper/src-tauri/hmac-0.13.0
Closed

chore(deps): Bump hmac from 0.12.1 to 0.13.0 in /apps/helper/src-tauri#1083
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/apps/helper/src-tauri/hmac-0.13.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026

Copy link
Copy Markdown
Contributor

Bumps hmac from 0.12.1 to 0.13.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [hmac](https://github.com/RustCrypto/MACs) from 0.12.1 to 0.13.0.
- [Commits](RustCrypto/MACs@hmac-v0.12.1...hmac-v0.13.0)

---
updated-dependencies:
- dependency-name: hmac
  dependency-version: 0.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github

dependabot Bot commented on behalf of github Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, rust, tauri. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 2, 2026

Copy link
Copy Markdown

Deploying breeze with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5018bd
Status: ✅  Deploy successful!
Preview URL: https://2e0e5b03.breeze-9te.pages.dev
Branch Preview URL: https://dependabot-cargo-apps-helper-40dm.breeze-9te.pages.dev

View logs

@ToddHebebrand

Copy link
Copy Markdown
Collaborator

Superseded by #1146.

Root cause this PR couldn't merge alone: sha2 0.11 and hmac 0.13 are a coupled pair — both pull in digest 0.11, which moved new_from_slice to the KeyInit trait. Merging either bump by itself breaks the helper build at apps/helper/src-tauri/src/ipc/envelope.rs:18, and PR CI never compiles the helper's Rust (only cargo-audit runs), so it would have merged green and broken the release build.

Fix: #1146 lands both bumps together with the one-line use hmac::{Hmac, KeyInit, Mac}; import fix, verified with cargo check --locked --all-targets and the helper's 33 unit tests (incl. the Go-compatible HMAC parity tests). It also adds a rust-check CI job so future Cargo bumps are compile-checked at PR time.

Dependabot should close this automatically once #1146 merges.

ToddHebebrand added a commit that referenced this pull request Jun 9, 2026
…fix; add rust-check CI job (#1146)

## Why

Supersedes the coupled dependabot pair **#1082** (sha2 0.10→0.11) and
**#1083** (hmac 0.12→0.13). Both pull in digest 0.11, and merging either
alone breaks the helper build: digest 0.11 moved `new_from_slice` to the
`KeyInit` trait. Neither could merge safely because **PR CI never
compiles the helper's Rust** — only cargo-audit (an advisory-DB scan)
runs; the real build happens only in the release workflow.

## What

- **Bump** `sha2 = "0.11"`, `hmac = "0.13"` in
`apps/helper/src-tauri/Cargo.toml` + lockfile.
- **Fix** `apps/helper/src-tauri/src/ipc/envelope.rs:18` — import
`KeyInit` alongside `Mac` so `Hmac::new_from_slice` compiles under
digest 0.11.
- **New CI job `rust-check`** — `cargo check --locked --all-targets` for
`apps/helper/src-tauri` **and** `apps/viewer/src-tauri` on every PR,
using the same apt deps, pinned toolchain action, and rust-cache setup
as the release workflow. Closes the merge-green-break-release blind spot
this pair demonstrated. Non-blocking (not in the `ci-success` needs
list) until its runtime/caching is proven.

## Verification

- `cargo check --locked --all-targets` clean for **both** apps locally
(macOS).
- `cargo test` in the helper: **33 passed**, including the Go-compatible
HMAC envelope parity tests that exercise the `KeyInit` code path.
- The `rust-check` job runs on this very PR, so the bump is
compile-verified in CI before merge.

## Notes

- **#1081** (windows 0.58→0.61) is intentionally NOT included: it's
`[target.'cfg(windows)']`-gated, so neither macOS nor the ubuntu
rust-check job compiles it — only the Windows release build can verify
it. It stays held.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@ToddHebebrand

Copy link
Copy Markdown
Collaborator

Closing — superseded by #1146 (merged), which lands this bump together with sha2 0.11 and the required KeyInit import fix.

@dependabot @github

dependabot Bot commented on behalf of github Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/cargo/apps/helper/src-tauri/hmac-0.13.0 branch June 9, 2026 18:31
ToddHebebrand added a commit that referenced this pull request Jun 9, 2026
…dows cargo check, dependabot staggering (#1165)

## Why

Follow-up to the June red-main postmortem (#1144/#1146), with one
organizing principle: **nothing is red by default — red means act now.**
Main was red for 8 days partly because chronic background red trained
everyone to ignore it.

## What

**Blocking integration tests** — the API integration suite moves out of
the non-blocking smoke-test job into its own `integration-test` job,
required on PRs *and* main via `ci-success`. This is the gate that would
have stopped #1042 and #1092 from merging. It boots only
`docker-compose.test.yml` (no image builds) — ~2-3 min. The smoke job
keeps the Docker build + endpoint smoke, still non-blocking on PRs.
`rust-check` is promoted to required as well.

**`bail: 1` removed** from the integration config — it surfaced only the
first failure per run, which hid #1092's lockout behind #1042's 403 for
a day.

**Main-red alerting** — a `main-red-alert` job keeps exactly one open
`ci-red` issue while main is red and auto-closes it on the next green
main push. Cancelled runs (dependabot storms) are ignored. One loud,
self-resolving signal instead of a wall of silently-cancelled runs.

**`rust-check-windows`** — compiles both Tauri apps on a windows runner,
path-filtered to `src-tauri/**` changes, closing the `cfg(windows)` gap
the ubuntu rust-check can't cover (the #1081 problem). Skipped (fast,
green) on non-Cargo PRs.

**Workflow Lint job** (security workflow) — actionlint core checks +
zizmor at medium severity, both verified green against this tree before
gating. shellcheck integration is deliberately off (release.yml's 13
style nits would make it perma-red). `.github/zizmor.yml` encodes the
pin policy (first-party actions float on tags, everything else
hash-pinned) and the one accepted finding class (release build caches).
zizmor's first sweep also scoped `security-events: write` per-job and
added missing least-privilege `permissions:` blocks to three workflows.

**Dependabot staggering + coupling groups** — npm Monday, Go Tuesday,
Actions Wednesday, Cargo Thursday (no more Monday merge storm), plus
groups for deps that break when bumped solo: `mobile`
(expo/react-native/metro), `aws-sdk` (gomod), `rustcrypto` (the
sha2/hmac pair from #1082/#1083).

**Local-flake kill** — `audit-logs-rls.integration.test.ts` used
hardcoded resourceIds against the append-only `audit_logs` table, so
every second local run failed on accumulated rows (the "clear audit_logs
between runs" papercut). Per-run UUIDs fix it; verified by running the
suite twice against a dirty DB — 91/91 green both times.

## Deliberately deferred

A nightly Playwright e2e job is viable but the suite currently has a
broken import (`test-helpers.ts` doesn't exist) and unverified seed data
for the catalog specs — shipping it now would create a red-by-default
job. Tracked as a follow-up.

## Verification

- `actionlint -shellcheck=` and `zizmor --min-severity medium` exit 0
across all workflows locally.
- Integration suite (no-bail config): 22 files / 91 tests green, twice,
against a dirty DB.
- The new `integration-test`, `rust-check-windows` (skip path), and
`workflow-lint` jobs all run on this very PR.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant