[core] [sql] Add spawn group plumbing

[WinterSolstice8]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds spawn group/spawn slot plumbing
Only these mobs in Korroloka Tunnel are hooked up atm

The rest are ungrouped

Steps to test these changes

zone to Korroloka Tunnel
!gotoname Clipper 10
Kill grouped/ungrouped mobs, see them respawn correctly. In the case of grouped mobs, some should cycle in/out.

[WinterSolstice8]

TODO: Night/Day only spawn checks. It doesnt look like we have enough data to know how exactly that works

[UmeboshiXI]

TODO: Night/Day only spawn checks. It doesnt look like we have enough data to know how exactly that works

Just some info. A good test case for this might be the Ceremonial Dagger drop.

Dagger drops off skeletons that only spawn at night but they share spawns with 2 goblins at the same location.

[Frankie-hz]

Another note: when you despawn a mob because of distance it respawns in 80-90 seconds. Trying to narrow down the timer a little more but it seems to be around there. Testing a bunch of things to narrow some more things down.

It does NOT always spawn the same id. It can pick anything from the pool.

[WinterSolstice8]

I think this is good to go, though I don't have the night/day spawn in stuff yet. That can come in a future PR. This PR won't break anything that's not in a group (and it only adds ONE group) so i don't think it's a problem

We're working on getting info on how the night/day only spawns/transitions works (unfortunately it's hard to test due to really only being able to do it once per game day on retail...)

[Frankie-hz]

Everything seems to work. Killed all mobs several times at once, staggered, etc. always spawned with correct number of spawns and correct mob IDs.

[MowFord]

looks sane and very light on the manual data entry.

Have you thought at all on lua bindings to allow definitions in mob lua alongside (or instead of) the sql data?

My thought was perhaps the spawn groups being able to be the lowest mobid in the group. I think spawn_group.h defines it as uint32, but the sql table is only tinyint. This should be fine since we don't want hardcoded mobids in the sql table anyway, just sharing my thoughts on the future of the system

[Frankie-hz]

I might not be understanding what you mean but the groups aren't always in specific ID order. There are several cases where that is not true and the groups skip IDs.

This is somewhat hardcoded anyway because groupings need to be assigned to specific mob ids.

[MowFord]

absolutely, my point is that if we were to assign spawn groups in onMobInit functions, we'd need a clean way to not step on the toes of other existing groups:

• one way is to loop over and get the next unused
• another way is to just use a mobid as the spawn group unique ID

[zach2good]

I spoke to Winter about the C++ and performance characteristics of this last week, should all be good 👍

[WinterSolstice8]

Need to retest this after a conflict from rebase once I get home