feat: add account search to account list#109
Conversation
emreertunc
left a comment
There was a problem hiding this comment.
Thanks for the implementation. I found one edge case that needs to be fixed before approval.
When a search query is active and the account count drops from 8 to 7, the search input is hidden because the threshold is no longer met, but the query remains active and continues filtering the account list.
For example, with exactly 8 accounts, search for an account that is the only match and then delete it. The UI displays “No matching accounts,” while the search field and its clear button are no longer available.
Please clear the query or disable filtering whenever the account count falls below the search threshold.
The search field was hidden below eight accounts while its query still filtered the list. Gate the effective query by the same threshold and clear stale search state when search is disabled.
|
Addressed the requested 8 -> 7 account edge case in commit 25a32b0.
The PR head is now 25a32b0 and is ready for re-review. |
|
Thanks for the contribution! |
What changed
Why
This addresses the real-world multi-account workflow described in #101 without adding UI clutter for the common 2–3 account case.
Impact
Checks
pnpm build(tsc && vite build)No screenshots are attached because the real account list contains private email addresses.