Skip to content

Fix color temp for lights#215

Closed
bdraco wants to merge 1 commit intoLaggAt:masterfrom
bdraco:kelvin_reversed
Closed

Fix color temp for lights#215
bdraco wants to merge 1 commit intoLaggAt:masterfrom
bdraco:kelvin_reversed

Conversation

@bdraco
Copy link
Copy Markdown

@bdraco bdraco commented Jan 18, 2025

  • The min and max was reversed
  • The color_temp_kelvin property should be used since its in kelvin not mireds

This caused a few issues for HomeKit users
home-assistant/core#135222 home-assistant/core#135401 home-assistant/core#135358

Disclaimer: I don't use this integration and don't have any way to test this

- The min and max was reversed
- The color_temp_kelvin property should be used since its in kelvin not mireds

This caused a few issues for HomeKit users
home-assistant/core#135222
home-assistant/core#135401
home-assistant/core#135358
Copy link
Copy Markdown

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiriBalcar
Copy link
Copy Markdown
Collaborator

It is already in #201

@bdraco bdraco closed this Mar 9, 2025
@bdraco bdraco deleted the kelvin_reversed branch March 9, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants