Update MCHub details #2087
Closed
Update MCHub details #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as an information regarding your wildcards:
Please make sure it is an actual wildcard. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
- Please add a name or a color to the gamemode prison
- Please add a name or a color to the gamemode skyblock
- Please add a name or a color to the gamemode dungeons
Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.
DoJapHD
requested changes
Sep 3, 2025
There was a problem hiding this comment.
Wrong size, has to be 256x256px
There was a problem hiding this comment.
Wrong size. Has to be 512x512px
| "server_wildcards": [ | ||
| "%.mchub.com" | ||
| "%.mchub.com", | ||
| "%.skyblocky.com", |
There was a problem hiding this comment.
Not a wildcard
https://i.imgur.com/J26v08p.png
| "%.mchub.com" | ||
| "%.mchub.com", | ||
| "%.skyblocky.com", | ||
| "%.mcprison.com" |
There was a problem hiding this comment.
Not a wildcard
https://i.imgur.com/mKeuMYH.png
| "name": "Prison" | ||
| }, | ||
| "skyblock": { | ||
| "name": "Skyblock" |
| "survival": { | ||
| "name": "Survival" | ||
| "dungeons": { | ||
| "name": "Dungeons" |
|
Commited updates |
There was a problem hiding this comment.
- Invalid wildcard entry. Each entry must start with %.. Further information here: https://en.wikipedia.org/wiki/Wildcard_DNS_record (
server_wildcards) - Invalid wildcard entry. Each entry must start with %.. Further information here: https://en.wikipedia.org/wiki/Wildcard_DNS_record (
server_wildcards)
Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.
DoJapHD
requested changes
Sep 4, 2025
| "server_wildcards": [ | ||
| "%.mchub.com" | ||
| "%.mchub.com", | ||
| "skyblocky.com", |
| "%.mchub.com" | ||
| "%.mchub.com", | ||
| "skyblocky.com", | ||
| "mcprison.com" |
|
Inactive PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist
Further comments