-
Notifications
You must be signed in to change notification settings - Fork 650
Update MCHub details #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MCHub details #2087
Conversation
Just as an information regarding your wildcards:
Please make sure it is an actual wildcard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a name or a color to the gamemode prison
- Please add a name or a color to the gamemode skyblock
- Please add a name or a color to the gamemode dungeons
Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add colour to prison gamemode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong size, has to be 256x256px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong size. Has to be 512x512px
"server_wildcards": [ | ||
"%.mchub.com" | ||
"%.mchub.com", | ||
"%.skyblocky.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a wildcard
https://i.imgur.com/J26v08p.png
"%.mchub.com" | ||
"%.mchub.com", | ||
"%.skyblocky.com", | ||
"%.mcprison.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a wildcard
https://i.imgur.com/mKeuMYH.png
"name": "Prison" | ||
}, | ||
"skyblock": { | ||
"name": "Skyblock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add colour
"survival": { | ||
"name": "Survival" | ||
"dungeons": { | ||
"name": "Dungeons" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add colour
Commited updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Invalid wildcard entry. Each entry must start with %.. Further information here: https://en.wikipedia.org/wiki/Wildcard_DNS_record (
server_wildcards
) - Invalid wildcard entry. Each entry must start with %.. Further information here: https://en.wikipedia.org/wiki/Wildcard_DNS_record (
server_wildcards
)
Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong size, 1280x720px.
"server_wildcards": [ | ||
"%.mchub.com" | ||
"%.mchub.com", | ||
"skyblocky.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a wildcard
"%.mchub.com" | ||
"%.mchub.com", | ||
"skyblocky.com", | ||
"mcprison.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a wildcard
Inactive PR |
Type of change
Checklist
Further comments