Skip to content

Firecrown 1.14 - #454

Open
joezuntz wants to merge 7 commits into
masterfrom
firecrown_114
Open

Firecrown 1.14#454
joezuntz wants to merge 7 commits into
masterfrom
firecrown_114

Conversation

@joezuntz

Copy link
Copy Markdown
Collaborator

This updates to being compatible with (and I assume) requiring FireCrown 1.14

@joezuntz
joezuntz requested a review from elvinpoole March 27, 2026 16:36

@elvinpoole elvinpoole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firecrown edits look good, but the NERSC install has an conflict with the numcosmo_py

Comment thread bin/perlmutter-install.sh

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this on NERSC

Looks like firecrown switched from setup.cfg to pyproject.toml so we need to add
sed -i '/numcosmo/d' pyproject.toml
For the install

However, the test then fails due to ModuleNotFoundError: No module named 'numcosmo_py'
Seems this wasn;t a required dependancy before but now it is
see the firecrown.module.cluster init before and after here:
https://github.com/LSSTDESC/firecrown/blob/v1.7.5/firecrown/models/cluster/__init__.py
https://github.com/LSSTDESC/firecrown/blob/v1.14.0/firecrown/models/cluster/__init__.py

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to fix by using mamba firecrown, but I now see an error with mpi, something totally different, so will need to investigate.

@joezuntz

Copy link
Copy Markdown
Collaborator Author

We may need to put the numcosmo dependency in the conda package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants