This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=========================================
- Coverage 7.53% 7.41% -0.12%
=========================================
Files 219 219
Lines 8694 8694
=========================================
- Hits 655 645 -10
- Misses 8039 8049 +10
Continue to review full report at Codecov.
|
chitowncrispy
suggested changes
Oct 11, 2019
chitowncrispy
approved these changes
Oct 14, 2019
ottosuess
suggested changes
Oct 14, 2019
| #### Helpful Tools and Next Steps | ||
| 1) Run `./setup.sh` to download the required frameworks. | ||
|
|
||
| 2) Run `bundle exec pod install` to install dependencies located in the `Podfile`. This command guarantees that the version of CocoaPods specified in the `Gemfile.lock` is used to `pod install` the dependencies listed in the `Podfile.lock`. |
Member
There was a problem hiding this comment.
you don't have to install pods. pod sources are committed to the repository (for the reasons mentioned here: https://stackoverflow.com/a/45587355).
all you have to do is run setup.sh and open Zap.xcworkspace
Author
There was a problem hiding this comment.
Oh awesome, will update shortly
ottosuess
force-pushed
the
master
branch
3 times, most recently
from
25a8d65 to
8320cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some small quality of life updates to
INSTALL.mdfor clarity, nothing groundbreaking :)Motivation and Context
I just want to make it easier for people to install and get started and have less questions for existing devs.
How Has This Been Tested?
I proof-read it 😄
Types of changes
Copy update
Checklist: