Alarm: add Dismiss option to Jive alarm popup#1564
Open
boudekerk wants to merge 1 commit intoLMS-Community:public/9.2from
Open
Alarm: add Dismiss option to Jive alarm popup#1564boudekerk wants to merge 1 commit intoLMS-Community:public/9.2from
boudekerk wants to merge 1 commit intoLMS-Community:public/9.2from
Conversation
Extends `stop()` with an optional `$continueAudio` flag. When true, all player-state restores (analogOut, volume, shuffle, power) are skipped, leaving playback running while the alarm UI is dismissed. The `jivealarm` command now accepts a `continueAudio:1` parameter which is forwarded to `stop()`. This wires up the new Dismiss menu item that will be added to the AlarmSnoozeApplet on SqueezePlay/squeezeos clients. As a side-effect this also fixes the `cancelAction` (Back button on device) behaviour: the Lua client already called `stopAlarm(true)` for Back, but the server was unconditionally restoring player state anyway. Signed-off-by: Bartosz Oudekerk <lot+github@unreachablehost.net>
This was referenced May 2, 2026
Member
|
Chicken and egg... I guess the other two PRs need this change to work? What if a user had the client side changes, but not this one? |
Contributor
Author
Server ignores the extra param. Same as stop effectively, no existing functionality touched, no harm done. |
Member
|
I'm sorry, merged the other PR first - now this one is conflicting. Could you please resolve the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slim::Utils::Alarm::stop()with an optional$continueAudioflag. When true, all player-state restores (analogOut, volume, shuffle, power) are skipped so playback continues uninterrupted.jivealarmcommand now accepts acontinueAudio:1parameter, forwarded tostop().As a side-effect this also fixes the
cancelAction(Back button on device) behaviour: the Lua client already sentstopAlarm(true)for Back, but the server was unconditionally restoring player state anyway.Backward compatible: old clients that don't send
continueAudiodefault to0, preserving existing behaviour.Related
Companion PRs (client side, independent):