fix: transaction serialized with access list #2205
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDT-web3j#2204 Signed-off-by: zouxyan <[email protected]>
3 tasks
|
@zouxyan please build and run locally to fix it |
mskrzypkows
reviewed
Jul 30, 2025
|
|
||
| // access list | ||
| resultTx.add(new RlpList()); | ||
| result.add(new RlpList(rlpAccessListRlp())); |
There was a problem hiding this comment.
Are you sure you want to change it from resultTx to result? I think it should stay in resultTx: https://eips.ethereum.org/EIPS/eip-4844
Signed-off-by: zouxyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2204
What does this PR do?
To fix #2204
Where should the reviewer start?
web3j/crypto/src/main/java/org/web3j/crypto/transaction/type/Transaction4844.java
Line 142 in 45dcf26
Why is it needed?
To send blob tx with access list correctly
Checklist