-
Notifications
You must be signed in to change notification settings - Fork 100
Add text translatable fallback method #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add text translatable fallback method #981
Conversation
.fallback(String text)
for translatable.fallback(String text)
for Text Translatable
.fallback(String text)
for Text TranslatableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not compile. Please test your changes before making a PR, using the GitHub web editor to make changes isn't a great idea because you cannot test it there (and it doesn't show syntax errors).
I'm not sure I like the idea of adding this to all components, as it is only usable for translatable components and not literal/keybind/nbt/score ect components. |
This feature still needs more corrections, I will continue to study how to make this feature better |
which one is better?
|
I would opt to add a new method with a different name to prevent ambiguity issues. I.E. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Add
.fallback(String text)
forText.translate()
Example Script
Other details
This is my first submission, so I may need more suggestions to improve this feature.