-
Notifications
You must be signed in to change notification settings - Fork 3
Draft: Add update sdk url #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlexyPellegrini
wants to merge
19
commits into
Kitware:main
Choose a base branch
from
AlexyPellegrini:add-update-sdk-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls a tar.xz archive from https://vtk.org/files/wheel-sdks and package it as a wheel using scikit-build-core. This wheel will then be added to a pip repository to be fetch through build requirements.
Do not rely on scikit-build-core automatic package discovery and explicitly install content of the vtk-sdk archive into a dedicated sub-directory.
Anticipating the introduction of checksum verification, the vtk-sdk archive version will be a static parameter.
Use python, abi and platform tag terminology to match specification. See https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/
Exclude Python 3.12 not supported with VTK 9.2.5 SDKs
The vtk-sdk is expected to be distributed as-is without being modified using default repair commands. See https://cibuildwheel.pypa.io/en/1.x/options/#repair-wheel-command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL are gathered from the new "SHA256.txt" files on https://vtk.org/files/wheel-sdks/ for given version.
This branch should be rebased on main once #2 is merged!