Fix image to texture conversion #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust stride computation in image to texture conversion. We want strides reported in bytes, and our logic to check for valid strides is based on the same, however KWIVER reports strides in increments of the value type. This was fine for 8-bit images and seems to have been working by accident for single-channel 16-bit images, but was causing the stride check to incorrectly reject some multi-channel 16-bit images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust stride computation in image to texture conversion. We want strides reported in bytes, and our logic to check for valid strides is based on the same, however KWIVER reports strides in increments of the value type. This was fine for 8-bit images and seems to have been working by accident for single-channel 16-bit images, but was causing the stride check to incorrectly reject some multi-channel 16-bit images.