Skip to content

test: enable time-related tests in sql2016 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KKould merged 1 commit into from
Jul 20, 2025
Merged

test: enable time-related tests in sql2016 #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/types/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1783,10 +1783,7 @@ impl DataValue {
Ok(DataValue::Date64(value))
}
LogicalType::Time(p) => {
let p = match p {
Some(p) => *p,
None => 0,
};
let p = p.unwrap_or(0);
let (value, nano) = Self::from_timestamp_precision(value, precision)
.map(|date_time| {
(
Expand Down
26 changes: 12 additions & 14 deletions tests/slt/sql_2016/E153.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
# E153: Updatable queries with subqueries

# TODO: Updatable queries with subqueries
statement ok
CREATE TABLE TABLE_E153_01_01 ( A INT PRIMARY KEY, B INT );

# statement ok
# TABLE TABLE_E153_01_01 ( A INT, B INT );
statement ok
INSERT INTO TABLE_E153_01_01 VALUES ( 1, 2 );

# statement ok
# INSERT INTO TABLE_E153_01_01 VALUES ( 1, 2 );
statement ok
UPDATE TABLE_E153_01_01 SET A = 3, B = 4 WHERE A = ( SELECT 1 )

# statement ok
# UPDATE TABLE_E153_01_01 SET A = 3, B = 4 WHERE A = ( SELECT 1 )
statement ok
CREATE TABLE TABLE_E153_02_01 ( A INT PRIMARY KEY, B INT );

# statement ok
# CREATE TABLE TABLE_E153_02_01 ( A INT, B INT );
statement ok
INSERT INTO TABLE_E153_02_01 VALUES ( 1, 2 );

# statement ok
# INSERT INTO TABLE_E153_02_01 VALUES ( 1, 2 );

# statement ok
# DELETE FROM TABLE_E153_02_01 WHERE A = ( SELECT 1 )
statement ok
DELETE FROM TABLE_E153_02_01 WHERE A = ( SELECT 1 )
14 changes: 6 additions & 8 deletions tests/slt/sql_2016/F051_02.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# F051-02: TIME data type (including support of TIME literal) with fractional seconds precision of at least 0

# TODO: TIME
statement ok
CREATE TABLE TABLE_F051_02_01_011 ( PK INT PRIMARY KEY, A TIME )

# statement ok
# CREATE TABLE TABLE_F051_02_01_011 ( A TIME )

# query T
# SELECT TIME '01:02:03'
# ----
# 01:02:03
query T
SELECT TIME '01:02:03'
----
01:02:03
14 changes: 6 additions & 8 deletions tests/slt/sql_2016/F051_03.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# F051-03: TIMESTAMP data type (including support of TIMESTAMP literal) with fractional seconds precision of at least 0 and 6

# TODO: TIMESTAMP
statement ok
CREATE TABLE TABLE_F051_03_01_011 ( PK INT PRIMARY KEY, A TIMESTAMP )

# statement ok
# CREATE TABLE TABLE_F051_03_01_011 ( A TIMESTAMP )

# query T
# SELECT TIMESTAMP '2016-03-26 01:02:03'
# ----
# 2016-03-25T20:02:03-05:00
query T
SELECT TIMESTAMP '2016-03-26 01:02:03'
----
2016-03-26 01:02:03
122 changes: 59 additions & 63 deletions tests/slt/sql_2016/F051_04.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,66 +30,62 @@ SELECT DATE '2016-03-26' >= DATE '2016-03-26'
----
true

# TODO: TIME

# query B
# SELECT TIME '01:02:03' < TIME '01:02:03'
# ----
# false

# query B
# SELECT TIME '01:02:03' <= TIME '01:02:03'
# ----
# true

# query B
# SELECT TIME '01:02:03' <> TIME '01:02:03'
# ----
# false

# query B
# SELECT TIME '01:02:03' = TIME '01:02:03'
# ----
# true

# query B
# SELECT TIME '01:02:03' > TIME '01:02:03'
# ----
# false

# query B
# SELECT TIME '01:02:03' >= TIME '01:02:03'
# ----
# true

# TODO: TIMESTAMP

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' < TIMESTAMP '2016-03-26 01:02:03'
# ----
# false

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' <= TIMESTAMP '2016-03-26 01:02:03'
# ----
# true

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' <> TIMESTAMP '2016-03-26 01:02:03'
# ----
# false

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' = TIMESTAMP '2016-03-26 01:02:03'
# ----
# true

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' > TIMESTAMP '2016-03-26 01:02:03'
# ----
# false

# query B
# SELECT TIMESTAMP '2016-03-26 01:02:03' >= TIMESTAMP '2016-03-26 01:02:03'
# ----
# true
query B
SELECT TIME '01:02:03' < TIME '01:02:03'
----
false

query B
SELECT TIME '01:02:03' <= TIME '01:02:03'
----
true

query B
SELECT TIME '01:02:03' <> TIME '01:02:03'
----
false

query B
SELECT TIME '01:02:03' = TIME '01:02:03'
----
true

query B
SELECT TIME '01:02:03' > TIME '01:02:03'
----
false

query B
SELECT TIME '01:02:03' >= TIME '01:02:03'
----
true

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' < TIMESTAMP '2016-03-26 01:02:03'
----
false

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' <= TIMESTAMP '2016-03-26 01:02:03'
----
true

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' <> TIMESTAMP '2016-03-26 01:02:03'
----
false

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' = TIMESTAMP '2016-03-26 01:02:03'
----
true

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' > TIMESTAMP '2016-03-26 01:02:03'
----
false

query B
SELECT TIMESTAMP '2016-03-26 01:02:03' >= TIMESTAMP '2016-03-26 01:02:03'
----
true
92 changes: 41 additions & 51 deletions tests/slt/sql_2016/F051_05.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,71 +5,61 @@ SELECT CAST ( '2016-03-26' AS DATE )
----
2016-03-26

# TODO: TIME
# query T
# SELECT CAST ( '01:02:03' AS TIME )
# ----
# 01:02:03
query T
SELECT CAST ( '01:02:03' AS TIME )
----
01:02:03

# TODO: TIMESTAMP
# query T
# SELECT CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE )
# ----
# 2016-03-25T20:02:03-05:00
query T
SELECT CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE )
----
2016-03-26 01:02:03

query T
SELECT CAST ( CAST ( '2016-03-26' AS DATE ) AS VARCHAR )
----
2016-03-26

# TODO: TIME
# query T
# SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS VARCHAR )
# ----
# '01:02:03'
query T
SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS VARCHAR )
----
01:02:03

# TODO: TIMESTAMP
# query T
# SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS VARCHAR )
# ----
# '2016-03-26 01:02:03'
query T
SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS VARCHAR )
----
2016-03-26 01:02:03

# TODO: TIME
# query T
# SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS TIME )
# ----
# 01:02:03
query T
SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS TIME )
----
01:02:03

# TODO: TIME & TIMESTAMP
# pg style
# query I
# SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS TIMESTAMP )

# TODO: TIME
# query T
# SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS VARCHAR )
# ----
# '01:02:03'
query T
SELECT CAST ( CAST ( '01:02:03' AS TIME ) AS VARCHAR )
----
01:02:03

# TODO: TIMESTAMP
# query T
# SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS DATE )
# ----
# 2016-03-26
query T
SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS DATE )
----
2016-03-26

# TODO: TIME & TIMESTAMP
# query T
# SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS TIME )
# ----
# 01:02:03
query T
SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS TIME )
----
01:02:03

# TODO: TIMESTAMP
# query T
# SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS TIMESTAMP )
# ----
# 2016-03-25T20:02:03-05:00
query T
SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS TIMESTAMP )
----
2016-03-26 01:02:03

# TODO: TIMESTAMP
# query T
# SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS VARCHAR )
# ----
# '2016-03-26 01:02:03'
query T
SELECT CAST ( CAST ( '2016-03-26 01:02:03' AS TIMESTAMP WITHOUT TIME ZONE ) AS VARCHAR )
----
2016-03-26 01:02:03
Loading