Skip to content

fix(jetbrains): facelift session controls#12180

Merged
kirillk merged 8 commits into
mainfrom
fringe-passionfruit
Jul 13, 2026
Merged

fix(jetbrains): facelift session controls#12180
kirillk merged 8 commits into
mainfrom
fringe-passionfruit

Conversation

@kirillk

@kirillk kirillk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What changed

This PR is mostly a JetBrains session UI facelifting pass. It tightens prompt, progress, rollback, and editor chrome details so the session surface feels more native and consistent.

Features, one by one:

  • Improve rollback/redo scrolling so rollback waits for the visible marker and redo scrolls to the restored message instead of forcing the transcript bottom.
  • Share prompt editor chrome and font styling with the custom plan/question answer editor.
  • Show prompt and custom-answer editor scrollbars only when capped content overflows, using the standard auto-hiding editor scrollbar behavior.
  • Align the progress footer left inset with regular transcript content.
  • Add a right-aligned ticking elapsed timer to the progress footer, formatted as 59s, 1m 22s, and 1h 1m 22s.
  • Use IntelliJ's standard red stop icon for the prompt stop button.
  • Match the prompt send icon color to the scroll-to-bottom button in light and dark themes.
  • Add a standard separator before the prompt send button.
  • Match the prompt send-button right padding to the bottom padding by reusing the existing prompt shell padding value.

Why

These are mostly visual polish and native-feel improvements. The goal is to make JetBrains session controls, scroll behavior, and transient progress UI feel more consistent with IntelliJ platform conventions and with the rest of Kilo's session surface.

Verification

  • ./gradlew :frontend:test --tests 'ai.kilocode.client.session.ui.PromptPanelTest'
  • ./gradlew :frontend:test --tests 'ai.kilocode.client.session.ui.ProgressPanelTest'
  • ./gradlew :frontend:test --tests 'ai.kilocode.client.session.ui.PromptPanelTest' --tests 'ai.kilocode.client.session.views.QuestionViewTest'
  • ./gradlew :frontend:test --tests 'ai.kilocode.client.session.SessionScrollTest' --tests 'ai.kilocode.client.session.views.QuestionViewTest' --tests 'ai.kilocode.client.session.ui.PromptPanelTest'
  • ./gradlew typecheck
  • Push hook: bun turbo typecheck --filter=!@kilocode/kilo-jetbrains and bun turbo typecheck --filter=@kilocode/kilo-jetbrains

kirillk added 5 commits July 13, 2026 15:08
…lows cap

Both the main prompt editor and the custom question-response editor now
grow up to ~1/3 of the session root height, then enable a standard
auto-hiding vertical scrollbar (appears on scroll/hover, fades on
inactivity). While content fits, no scrollbar is shown.

- PromptPanel: syncEditorScroll toggles verticalScrollBarPolicy between
  VERTICAL_SCROLLBAR_NEVER and VERTICAL_SCROLLBAR_AS_NEEDED based on
  content vs capped height.
- QuestionView: same capped-height + auto-hiding scrollbar behavior for
  the custom-answer editor; also syncs on component resize and addNotify.
- Tests assert the policy flips correctly after overflow and returns to
  NEVER when content shrinks back to fit.
@kirillk kirillk changed the title fix(jetbrains): improve rollback scrolling and custom answer font fix(jetbrains): facelift session controls Jul 13, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/question/QuestionView.kt 128 Custom-editor height is not recomputed when only the session root height changes.
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/ProgressPanel.kt 127 Elapsed duration uses an adjustable wall clock instead of monotonic time.
Files Reviewed (18 files)
  • .changeset/jetbrains-platform-stop-icon.md - 0 issues
  • .changeset/jetbrains-progress-elapsed-time.md - 0 issues
  • .changeset/jetbrains-prompt-action-separator.md - 0 issues
  • .changeset/jetbrains-prompt-right-padding.md - 0 issues
  • .changeset/jetbrains-rollback-redo-font.md - 0 issues
  • .changeset/jetbrains-send-scroll-color.md - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/scroll/SessionScroll.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/ProgressPanel.kt - 1 issue
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/prompt/PromptPanel.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/style/SessionEditorStyle.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/question/QuestionView.kt - 1 issue
  • packages/kilo-jetbrains/frontend/src/main/resources/icons/send.svg - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/resources/icons/send_dark.svg - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/SessionScrollTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/ui/ProgressPanelTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/ui/PromptPanelTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/views/QuestionViewTest.kt - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summary (commit 5c98a0d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 5c98a0d)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/question/QuestionView.kt 128 Custom-editor height is not recomputed when only the session root height changes.
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/ProgressPanel.kt 127 Elapsed duration uses an adjustable wall clock instead of monotonic time.
Files Reviewed (18 files)
  • .changeset/jetbrains-platform-stop-icon.md - 0 issues
  • .changeset/jetbrains-progress-elapsed-time.md - 0 issues
  • .changeset/jetbrains-prompt-action-separator.md - 0 issues
  • .changeset/jetbrains-prompt-right-padding.md - 0 issues
  • .changeset/jetbrains-rollback-redo-font.md - 0 issues
  • .changeset/jetbrains-send-scroll-color.md - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/scroll/SessionScroll.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/ProgressPanel.kt - 1 issue
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/prompt/PromptPanel.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/style/SessionEditorStyle.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/question/QuestionView.kt - 1 issue
  • packages/kilo-jetbrains/frontend/src/main/resources/icons/send.svg - 0 issues
  • packages/kilo-jetbrains/frontend/src/main/resources/icons/send_dark.svg - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/SessionScrollTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/ui/ProgressPanelTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/ui/PromptPanelTest.kt - 0 issues
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/views/QuestionViewTest.kt - 0 issues

Fix these issues in Kilo Cloud


Reviewed by gpt-5.6-sol · Input: 147.4K · Output: 12.7K · Cached: 1M

Review guidance: REVIEW.md from base branch main

@kirillk
kirillk merged commit 00e1646 into main Jul 13, 2026
23 checks passed
@kirillk
kirillk deleted the fringe-passionfruit branch July 13, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants