Skip to content

Add GPT-5.6 Max effort#4474

Open
chrarnoldus wants to merge 1 commit into
mainfrom
christiaan/max
Open

Add GPT-5.6 Max effort#4474
chrarnoldus wants to merge 1 commit into
mainfrom
christiaan/max

Conversation

@chrarnoldus

Copy link
Copy Markdown
Contributor

@chrarnoldus chrarnoldus self-assigned this Jul 9, 2026
Comment thread packages/db/src/schema-types.ts
@kilo-code-bot

kilo-code-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Adding 'max' to ReasoningEffortSchema unintentionally exposes it as a selectable reasoning effort for all OpenAI models (not just GPT-5.6) in model-settings.ts, risking invalid reasoning_effort values being sent to the API for unsupported models.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/db/src/schema-types.ts 1561 max reasoning effort is offered to all OpenAI models via isOpenAiModel, not just GPT-5.6
Files Reviewed (2 files)
  • apps/web/src/lib/ai-gateway/providers/model-settings.ts
  • packages/db/src/schema-types.ts - 1 issue

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-5-20260630 · Input: 24 · Output: 8.5K · Cached: 659.7K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant